Use js.Any instead of interface{}. #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to change in gopherjs/gopherjs@1dae489.
|
LGTM. Thx. |
neelance
added a commit
that referenced
this pull request
Jan 17, 2015
Use js.Any instead of interface{}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to change in gopherjs/gopherjs@1dae489.
This fixes an issue upstream when trying to build
playground.go. The following snippet:Produces an error:
This PR fixes that problem and allows
playground.goto build successfully.I've applied the change to
SetValalso because it looks similar, but that is untested.Please review because I am not yet very familiar with
js.Any.