Improve gruvbox with C code

[cryptomilk]

Hi,

here are two small improvements. The first makes it easier to identify strings and the second displays compile errors/warnings more prominent. See the two pictures below:

gruvbox string improvement -> http://min.us/i/WV09c3thkZ1A
gruvbox error improvement ->http://minus.com/i/bpBizN0WkXLOJ

-- asn

[cryptomilk]

I've rebased it on the latest changes in master ...

[morhetz]

Once again it's not the something I would like to have in my default setup, though that sounds like it could be a nice option. Just gimmie a little bit of time to put my hands on.

[cryptomilk]

Ok, so I should make it possible to set a config option to get this behaviour?

[cryptomilk]

Ping!

[cryptomilk]

Here is a new version with options ...

[morhetz]

I must say sorry for a long hiatus on this issue, and I'm very grateful that you did it yourself. Merged.

[ghost]

Could you please post the screenshots here? The links are broken.

[lfilho]

The image links are dead, unfortunately. (Arrived here via Wiki https://github.com/morhetz/gruvbox/wiki/Configuration ). Thanks for everyone's work!

[rivertam]

Can we get some images of what this is supposed to do? I set g:gruvbox_improved_strings to both 1 and 0 and I didn't notice a difference as far as I could tell in both C and JavaScript. I'm just curious what it does.

[cryptomilk]

Here: https://xor.cryptomilk.org/pics/gruvbox_strings.png

let g:gruvbox_italicize_strings=0                                                                                                                                                        
let g:gruvbox_improved_strings=1                                                                                                                                                         

[rivertam]

@cryptomilk Thanks, so it adds the background? Still not clear on what "improved" means.

[cryptomilk]

Improved readability ;-)

[rpdelaney]

Improved readability ;-)

I still don't know what this does. You are saying why it does what it does, not what it does. Does it add the background? A before/after screenshot pair would be ideal

[hneis]

Improved readability ;-)

I still don't know what this does. You are saying why it does what it does, not what it does. Does it add the background? A before/after screenshot pair would be ideal

Improvement changes strings in quotes color(green) to normal color

[Climax777]

Improved readability ;-)

I still don't know what this does. You are saying why it does what it does, not what it does. Does it add the background? A before/after screenshot pair would be ideal

Improvement changes strings in quotes color(green) to normal color

I've noticed this too. I've opted to not use this feature because of that.

[marcelofern]

Same ^ Having a not-coloured string actually didn't help readability for me