Enable test of nsType with a collection view #1702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason this test was failing is due to a unified test runner bug, in which a view was created only when a pipeline was specified. JAVA-5679
jyemin
commented
May 1, 2025
| String viewOn = arguments.getString("viewOn").getValue(); | ||
| List<BsonDocument> pipeline = | ||
| arguments.getArray("pipeline").stream().map(BsonValue::asDocument).collect(toList()); | ||
| arguments.getArray("pipeline", new BsonArray()).stream().map(BsonValue::asDocument).collect(toList()); |
There was a problem hiding this comment.
If no pipeline provided, use an empty one.
|
LGTM - note I edited the description to point to the correct ticket JAVA-5769 |
rozza
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason this test fails is due to a unified test runner bug, in which a view is created only when a pipeline is specified.
JAVA-5769