Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error when AppArmor is unsupported and profile specified #5373

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

jarqvi
Copy link
Contributor

@jarqvi jarqvi commented Sep 30, 2024

For this PR:
moby/moby#48496

@github-actions github-actions bot added area/dependencies Pull requests that update a dependency file area/executor labels Sep 30, 2024
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR seems to contain some bogus containerd update

@jarqvi
Copy link
Contributor Author

jarqvi commented Oct 1, 2024

PR seems to contain some bogus containerd update

oh, i`m sorry.
please review again.

@jarqvi jarqvi requested a review from tonistiigi October 1, 2024 06:26
@thompson-shaun thompson-shaun changed the title Return error when AppArmor is unsupported and profile specifie Return error when AppArmor is unsupported and profile specified Oct 1, 2024
Signed-off-by: MohammadHasan Akbari <[email protected]>
@jarqvi
Copy link
Contributor Author

jarqvi commented Oct 2, 2024

@tonistiigi

i have no idea about failing tests

@jarqvi
Copy link
Contributor Author

jarqvi commented Oct 3, 2024

@tonistiigi
Again, some tests failed.

@tonistiigi tonistiigi merged commit d7978d1 into moby:master Oct 4, 2024
92 checks passed
@jarqvi jarqvi deleted the chore/apparmor branch October 4, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/executor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants