Static analyzer (PVS Studio) fixes #1372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should call delete on pointer instead of releasing it to the caller.
Enclose macro args in round brackets to ensure operators priority.
* Delete of void pointer is UB. See section 5.3.5/3. SO question: https://stackoverflow.com/questions/941832/is-it-safe-to-delete-a-void-pointer * Windows APIs used here return FALSE in case of failure, and non-FALSE on success. There is no info in spec that only TRUE value indicates success. Correct way to implement check for success call is to compare with false like result != FALSE.
Ensure + or - sign is used for time zone offset in RFC1123 military time format.
|
Build is broken due to artifacts to upload limit and name resolution failure. |
BillyONeal
approved these changes
Mar 31, 2020
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes from PVS Studio static analyzer.
Product page: https://www.viva64.com/en/pvs-studio/
How to use for free: https://www.viva64.com/en/b/0600/
Thanks for SDK, used that in own projects.