Regen #294
Regen #294
Conversation
package.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "azure-devops-node-api", | |||
| "description": "Node client for Azure DevOps and TFS REST APIs", | |||
| "version": "7.2.0", | |||
| "version": "7.3.0", | |||
There was a problem hiding this comment.
We need to discuss versioning before merging.
|
Were you able to test that all samples still run successfully? |
|
I hadn't before (probably should have marked this PR as draft) - looks like there are some breaking changes here actually (some parameters have been reordered. I think we need to bump the major version. I'll update the pr to update samples and package version. |
|
Looks like big changes are to build api and test api |
|
Should be good now. |
|
@stephenmichaelf can we merge? We still need to discuss major versioning, but this should definitely be a major version bump and it would be good to get it in |
|
Since it's been a little bit let's regen latest master and bump major. @bryanmacfarlane FYI. |
|
Done |
| "Dashboard", | ||
| "454b3e51-2e6e-48d4-ad81-978154089351", | ||
| routeValues); | ||
|
|
||
| let url: string = verData.requestUrl; | ||
| let url: string = verData.requestUrl!; |
There was a problem hiding this comment.
The generation code was changed to add the ! at the end. Did all of the samples still run successfully?
There was a problem hiding this comment.
Yep! I think there's actually no way that could break things - the only thing it does is loosen how strict the typescript compiler is on null checks (it basically says that this thing can never be null so don't worry about that case).
| @@ -11,8 +11,8 @@ | |||
| "use strict"; | |||
|
|
|||
| import DistributedTaskCommonInterfaces = require("../interfaces/DistributedTaskCommonInterfaces"); | |||
| import TFS_SourceControl_Contracts = require("./TfvcInterfaces"); | |||
| import TFS_TestManagement_Contracts = require("./TestInterfaces"); | |||
| import TFS_SourceControl_Contracts = require("../interfaces/TfvcInterfaces"); | |||
There was a problem hiding this comment.
Did we move these on purpose or is it because of regen changes?
There was a problem hiding this comment.
Just the regen, it has no practical impact though
There was a problem hiding this comment.
Do we not use those files here? How can we change the path but not move the file and it still works?
There was a problem hiding this comment.
The path is basically the same, we just change ./ to ../interfaces/ which is fine since we're already in the interfaces folder and they both just resolve to ./
|
Lots of new interfaces, are they all used? |
|
I think that's a mistake on my part, I'll clean that up. Good catch. |
|
Ok, got rid of the extra interfaces (and reran tests/samples successfully) |
|
Approve. Not sure why I don't see the approval button :) |
We shouldn't merge this until we publish 7.2.0