Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for windows dependency #1582

Merged

Conversation

bkneis
Copy link
Contributor

@bkneis bkneis commented Jan 20, 2025

OSS user discovered windows install failed due to missing dependency - #1573

This PR updates the docs to inform users of the required package

@pascalbreuninger
Copy link
Member

WebView2 should ship with most modern Windows Installations (10 and 11). Could you add that as a note for older windows installations please?
I'd like to avoid confusion where people go and look for WebView because for 99% it should already exist

@bkneis
Copy link
Contributor Author

bkneis commented Jan 20, 2025

WebView2 should ship with most modern Windows Installations (10 and 11). Could you add that as a note for older windows installations please? I'd like to avoid confusion where people go and look for WebView because for 99% it should already exist

Done :)

@bkneis bkneis requested a review from a team January 20, 2025 15:22
Copy link
Member

@pascalbreuninger pascalbreuninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascalbreuninger pascalbreuninger merged commit 223d831 into loft-sh:main Jan 20, 2025
1 check passed
@bkneis bkneis deleted the feature/update-docs-windows-install branch January 20, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants