Rename CODE_OWNERS -> Maintainers #114544
Conversation
|
@llvm/pr-subscribers-clang-tools-extra Author: Aaron Ballman (AaronBallman) ChangesFull diff: https://github.com/llvm/llvm-project/pull/114544.diff 2 Files Affected:
diff --git a/clang-tools-extra/CODE_OWNERS.TXT b/clang-tools-extra/CODE_OWNERS.TXT
deleted file mode 100644
index 2831ec7e25f59f..00000000000000
--- a/clang-tools-extra/CODE_OWNERS.TXT
+++ /dev/null
@@ -1,30 +0,0 @@
-This file is a list of the people responsible for ensuring that patches for a
-particular tool are reviewed, either by themself or by someone else. They are
-also the gatekeepers for their part of Clang, with the final word on what goes
-in or not.
-
-The list is sorted by surname and formatted to allow easy grepping and
-beautification by scripts. The fields are: name (N), email (E), Phabricator
-handle (H), and description (D).
-
-N: Aaron Ballman
-E: [email protected]
-H: aaron.ballman
-D: clang-query
-
-N: Julie Hockett
-E: [email protected]
-D: clang-doc
-
-N: Nathan James
-E: [email protected]
-H: njames93
-D: clang-tidy
-
-N: Manuel Klimek
-E: [email protected]
-D: all parts of clang-tools-extra not covered by someone else
-
-N: Sam McCall
-E: [email protected]
-D: clangd
diff --git a/clang-tools-extra/Maintainers.txt b/clang-tools-extra/Maintainers.txt
new file mode 100644
index 00000000000000..dc60b3717c63bb
--- /dev/null
+++ b/clang-tools-extra/Maintainers.txt
@@ -0,0 +1,42 @@
+=============================
+Clang Tools Extra Maintainers
+=============================
+
+This file is a list of the maintainers
+(https://llvm.org/docs/DeveloperPolicy.html#maintainers) for clang-tools-extra.
+
+
+Active Maintainers
+==================
+The following people are the active maintainers for the project. Please reach
+out to them for code reviews, questions about their area of expertise, or other
+assistance.
+
+Lead Maintainer
+---------------
+| Manuel Klimek
+| [email protected] (email), r4nt (GitHub)
+
+
+clang-query
+-----------
+| Aaron Ballman
+| [email protected] (email), aaron.ballman (Phabricator), AaronBallman (GitHub), AaronBallman (Discourse), aaronballman (Discord), AaronBallman (IRC)
+
+
+clang-doc
+---------
+| Julie Hockett
+| [email protected] (email)
+
+
+clang-tidy
+----------
+| Nathan James
+| [email protected] (email), njames93 (GitHub)
+
+
+clangd
+------
+| Sam McCall
+| [email protected] (email), sam-mccall (GitHub), sam-mccall (Discourse), sam-mccall (Discord)
|
|
I've kept everyone in the same position they were previously in, just reworded for the newer nomenclature. That said, I'd like explicit confirmation from @r4nt @njames93 and @sam-mccall that they're still willing and able to volunteer under the new maintainers guidance (https://llvm.org/docs/DeveloperPolicy.html#maintainers) before landing these changes. If you're not able to do so, that's totally fine! I can move you to the inactive maintainers part of the list and we can try to find other volunteers to step in to the role. Also, I cannot seem to find a GitHub handle for Julie Hockett and her last community interactions seem to be from 2021. If someone can help find the correct information and tag her on the review, that would be appreciated. |
|
I just no longer have the time needed to hold maintainer status. I'll still contribute as and when I have the time. |
Thank you for your help! I'll move you to the inactive maintainers list, and if you find you have more time in the future to step back into a maintenance role, we'll happily move you back to active status. |
Based on review feedback from Nathan -- thank you for all the help!
|
Ping @r4nt and @sam-mccall |
Yes, but it was a bad intention. :-D This is a .txt file, so we don't need to escape the |
Manuel has been unresponsive on the PR and the post on Discourse, but he had previously stepped down as a component maintainer in Clang due to a lack of bandwidth, so I think it's safe to move him to the inactive list. If he wants to be lead again, I'll happily pass the duties back to him.
|
As I mentioned on the Discourse post, I've moved @r4nt to be an emeritus lead maintainer and put myself in the role as a stopgap. |
|
Ping @llvm-beanz and @PeterChou1 for final-sign off before I can land this. |
|
@PiotrZSL The ping was in case you want to be added as a maintainer to clang-tidy as well. I’m mentioning it just to make sure. |
The designation of "maintainer" does not impact the established process. This role primarily introduces additional responsibilities without offering any demonstrable advantages. It is likely to become dead in the near future, mirroring the fate of the code owner role. At the end, being or not being a maintainer has no impact on me. |
I think it will help the first time contributor in this sub project to find correct one who can review their pr. But it is definitely not a mandatory thing. |
It does -- it helps newcomers figure out who can help them with reviews, answering questions, etc.
The only advantage to the maintainer is to get published credit for their increased responsibilities in the community, which isn't an advantage for everyone. The primary advantage is for the community.
The project has had this same concept in some form or fashion for at least 15 years now, so I don't think this is an accurate view.
There's no pressure to sign up to be one, but having a dedicated group of listed, active maintainers makes it more likely the project will thrive. FWIW, projects without active maintainers are starting to be removed or subsumed and I expect we'll continue to do that into the future. |
Co-authored-by: Piotr Zegar <[email protected]>
No description provided.