Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MeshService): don't exclude kuma.io/service if using reachableBackends #11301

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Sep 4, 2024

This also adds e2e tests for meshServices.enabled: ReachableBackendRefs.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- Support MeshService migration #11208
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont michaelbeaumont force-pushed the fix/reachable-backends-meshservice branch from f55fbb9 to 6066433 Compare September 4, 2024 12:52
@michaelbeaumont michaelbeaumont marked this pull request as ready for review September 4, 2024 14:17
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner September 4, 2024 14:17
@michaelbeaumont michaelbeaumont requested review from jijiechen and Icarus9913 and removed request for a team September 4, 2024 14:17
@michaelbeaumont michaelbeaumont force-pushed the fix/reachable-backends-meshservice branch from a82fbe4 to 38d71c2 Compare September 4, 2024 20:44
@michaelbeaumont michaelbeaumont force-pushed the fix/reachable-backends-meshservice branch from 38d71c2 to 301d675 Compare September 5, 2024 08:44
@michaelbeaumont michaelbeaumont merged commit 932be2b into kumahq:master Sep 5, 2024
15 checks passed
@michaelbeaumont michaelbeaumont deleted the fix/reachable-backends-meshservice branch September 5, 2024 11:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants