Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MeshService): automatically add port name when generating #11210

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

michaelbeaumont
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- Part of Support MeshService migration #11208
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner August 26, 2024 13:10
@michaelbeaumont michaelbeaumont requested review from bartsmykla and lukidzi and removed request for a team August 26, 2024 13:10
@michaelbeaumont michaelbeaumont merged commit dd6a047 into kumahq:master Aug 26, 2024
15 checks passed
@michaelbeaumont michaelbeaumont deleted the feat/ms-auto-port branch August 26, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants