fix(hostnamegenerator): selectors validation and matching #10688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
5 tasks
lukidzi
reviewed
Jul 1, 2024
pkg/core/resources/apis/hostnamegenerator/api/v1alpha1/hostnamegenerator.go
Outdated
Show resolved
Hide resolved
lukidzi
approved these changes
Jul 1, 2024
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
slonka
approved these changes
Jul 2, 2024
| selectorsDefined++ | ||
| } | ||
| if selectorsDefined != 1 { | ||
| verr.AddViolationAt(path, "exact one selector (meshService, meshExternalService) must be defined") |
There was a problem hiding this comment.
nitpick:
Suggested change
| verr.AddViolationAt(path, "exact one selector (meshService, meshExternalService) must be defined") | |
| verr.AddViolationAt(path, "exactly one selector (meshService, meshExternalService) must be defined") |
| ErrorCase("spec.selector empty", | ||
| validators.Violation{ | ||
| Field: `spec.selector`, | ||
| Message: `exact one selector (meshService, meshExternalService) must be defined`, |
There was a problem hiding this comment.
Suggested change
| Message: `exact one selector (meshService, meshExternalService) must be defined`, | |
| Message: `exactly one selector (meshService, meshExternalService) must be defined`, |
| ErrorCase("spec.selector has too many selectors", | ||
| validators.Violation{ | ||
| Field: `spec.selector`, | ||
| Message: `exact one selector (meshService, meshExternalService) must be defined`, |
There was a problem hiding this comment.
Suggested change
| Message: `exact one selector (meshService, meshExternalService) must be defined`, | |
| Message: `exactly one selector (meshService, meshExternalService) must be defined`, |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
I noticed a bug when implementing hostnames for MeshMultiZoneService.
If we define this HostnameGenerator
It also selects MeshExternalServices.
It does not make sense to have one HostnameGenerator for MeshExternalService, MeshService, so we should require exact one field in Selectors.
Additionally,
MeshServiceandMeshExternalServicefields were not pointers so it was impossible to distinguishfrom
I also added builders, but not samples because we are still unsure what good default values are.
syscall.Mkfifohave equivalent implementation on the other OS --ci/labels to run additional/fewer testsUPGRADE.md? --