Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp): index generated certs by proxy type #10161

Merged
merged 5 commits into from
May 6, 2024
Merged

fix(kuma-cp): index generated certs by proxy type #10161

merged 5 commits into from
May 6, 2024

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented May 3, 2024 •
edited
Loading

We were generating ZoneEgress and Dataplane certs and indexing them by name only

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner May 3, 2024 16:43
@michaelbeaumont michaelbeaumont requested review from slonka, jakubdyszkiewicz and lobkovilya and removed request for a team May 3, 2024 16:43
@lahabana
Copy link
Contributor

lahabana commented May 3, 2024

We were generating ZoneEgress and Dataplane certs and indexing them by name only

Was this causing any problem?

@michaelbeaumont
Copy link
Contributor Author

Was this causing any problem?

Not that I know of, but the code is just incorrect. Especially important for #10160

@michaelbeaumont michaelbeaumont enabled auto-merge (squash) May 6, 2024 09:08
@michaelbeaumont michaelbeaumont merged commit e9ff0ab into kumahq:master May 6, 2024
15 checks passed
@michaelbeaumont michaelbeaumont deleted the fix/proxy-type-certs branch May 6, 2024 09:09
michaelbeaumont added a commit that referenced this pull request May 6, 2024
@michaelbeaumont
fix(kuma-cp): index generated certs by proxy type (#10161)
6607efd 
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont added a commit that referenced this pull request May 6, 2024
@michaelbeaumont
fix(kuma-cp): index generated certs by proxy type (#10161)
faf4649 
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont added a commit that referenced this pull request May 6, 2024
@michaelbeaumont
fix(kuma-cp): index generated certs by proxy type (#10161)
7153fbd 
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont added a commit that referenced this pull request May 6, 2024
@michaelbeaumont
fix(kuma-cp): index generated certs by proxy type (#10161)
e0f5936 
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont added a commit that referenced this pull request May 6, 2024
@kumahq @michaelbeaumont @bartsmykla
fix(kuma-cp): consistently check for expiring ZoneIngress/ZoneEgress …
ee495c1 
…certs (backport of #10160, #10162, #10161) (#10170)

* fix(kuma-cp): consistently check for expiring ZoneIngress/ZoneEgress certs (#10160)

Signed-off-by: Mike Beaumont <[email protected]>

* fix(kuma-cp): cleanup generated egress certs (#10162)

Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Bart Smykla <[email protected]>

* fix(kuma-cp): index generated certs by proxy type (#10161)

Signed-off-by: Mike Beaumont <[email protected]>

---------

Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Mike Beaumont <[email protected]>
Co-authored-by: Bart Smykla <[email protected]>
michaelbeaumont added a commit that referenced this pull request May 6, 2024
@kumahq @michaelbeaumont @bartsmykla
fix(kuma-cp): consistently check for expiring ZoneIngress/ZoneEgress …
6808a51 
…certs (backport of #10160, #10162, #10161) (#10169)

* fix(kuma-cp): consistently check for expiring ZoneIngress/ZoneEgress certs (#10160)

Signed-off-by: Mike Beaumont <[email protected]>

* fix(kuma-cp): cleanup generated egress certs (#10162)

Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Bart Smykla <[email protected]>

* fix(kuma-cp): index generated certs by proxy type (#10161)

Signed-off-by: Mike Beaumont <[email protected]>

---------

Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Mike Beaumont <[email protected]>
Co-authored-by: Bart Smykla <[email protected]>
michaelbeaumont added a commit that referenced this pull request May 6, 2024
@kumahq @michaelbeaumont @bartsmykla
fix(kuma-cp): consistently check for expiring ZoneIngress/ZoneEgress …
456b88a 
…certs (backport of #10160, #10162, #10161) (#10166)

* fix(kuma-cp): consistently check for expiring ZoneIngress/ZoneEgress certs (#10160)

Signed-off-by: Mike Beaumont <[email protected]>

* fix(kuma-cp): cleanup generated egress certs (#10162)

Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Bart Smykla <[email protected]>

* fix(kuma-cp): index generated certs by proxy type (#10161)

Signed-off-by: Mike Beaumont <[email protected]>

---------

Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Mike Beaumont <[email protected]>
Co-authored-by: Bart Smykla <[email protected]>
michaelbeaumont added a commit that referenced this pull request May 6, 2024
@kumahq @michaelbeaumont @bartsmykla
fix(kuma-cp): consistently check for expiring ZoneIngress/ZoneEgress …
1dd64ef 
…certs (backport of #10160, #10162, #10161) (#10168)

* fix(kuma-cp): consistently check for expiring ZoneIngress/ZoneEgress certs (#10160)

Signed-off-by: Mike Beaumont <[email protected]>

* fix(kuma-cp): cleanup generated egress certs (#10162)

Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Bart Smykla <[email protected]>

* fix(kuma-cp): index generated certs by proxy type (#10161)

Signed-off-by: Mike Beaumont <[email protected]>

---------

Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Mike Beaumont <[email protected]>
Co-authored-by: Bart Smykla <[email protected]>
michaelbeaumont added a commit to michaelbeaumont/kuma that referenced this pull request May 6, 2024
@michaelbeaumont
fix(kuma-cp): index generated certs by proxy type (kumahq#10161)
bd37f88 
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont added a commit that referenced this pull request May 7, 2024
@michaelbeaumont @bartsmykla
fix(kuma-cp): index generated certs by proxy type, cleanup generated …
52ed9f9 
…egress certs (backport of #10161, #10162) (#10171)

* fix(kuma-cp): cleanup generated egress certs (#10162)

Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Bart Smykla <[email protected]>

* fix(kuma-cp): index generated certs by proxy type (#10161)

Signed-off-by: Mike Beaumont <[email protected]>

---------

Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Bart Smykla <[email protected]>
lobkovilya pushed a commit that referenced this pull request May 15, 2024
@michaelbeaumont @lobkovilya
fix(kuma-cp): index generated certs by proxy type (#10161)
8a83c83 
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
@BrewTestBot BrewTestBot mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla bartsmykla approved these changes

@slonka slonka Awaiting requested review from slonka slonka is a code owner automatically assigned from kumahq/kuma-maintainers

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz jakubdyszkiewicz is a code owner automatically assigned from kumahq/kuma-maintainers

@lobkovilya lobkovilya Awaiting requested review from lobkovilya lobkovilya is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelbeaumont @lahabana @bartsmykla