Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transparent-proxy): stop logging all to stderr when installing tproxy (backport of #10045) #10050

Merged
merged 2 commits into from
Apr 23, 2024
Merged

fix(transparent-proxy): stop logging all to stderr when installing tproxy (backport of #10045) #10050

merged 2 commits into from
Apr 23, 2024

Conversation

kumahq[bot]
Copy link
Contributor

@kumahq kumahq bot commented Apr 23, 2024

Automatic cherry-pick of #10045 for branch release-2.5

Generated by action

cherry-picked commit de0f8b5
⚠️ ⚠️ ⚠️ Conflicts happened when cherry-picking! ⚠️ ⚠️ ⚠️

On branch release-2.5
Your branch is up to date with 'origin/release-2.5'.

You are currently cherry-picking commit de0f8b52b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   pkg/transparentproxy/iptables/builder/builder_restore.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   pkg/transparentproxy/iptables/builder/builder.go

@bartsmykla @kumahq
fix(transparent-proxy): stop logging all to stderr when installing tp…
955a355 
…roxy (#10045)

Because of the construction of the log line, where everything was
located at the same line, we were not able to figure out at the
beginnig of the log if it'll be successfull or not, so everything
was logged in stderr. It's wrong when you have a monitoring set
to watch stderr. I changed it so now the same information is
placed in multiple lines and only failure is send to stderr.

Signed-off-by: Bart Smykla <[email protected]>
@kumahq kumahq bot requested a review from a team as a code owner April 23, 2024 12:08
@kumahq kumahq bot requested review from michaelbeaumont, jakubdyszkiewicz and lukidzi and removed request for a team April 23, 2024 12:08
@bartsmykla
chore: fix conflicts
cb5056e 
Signed-off-by: Bart Smykla <[email protected]>
@bartsmykla bartsmykla enabled auto-merge (squash) April 23, 2024 12:29
@bartsmykla bartsmykla merged commit ed4934f into release-2.5 Apr 23, 2024
5 checks passed
@bartsmykla bartsmykla deleted the chore/backport-release-2.5-10045 branch April 23, 2024 13:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla bartsmykla approved these changes

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont michaelbeaumont is a code owner automatically assigned from kumahq/kuma-maintainers

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz jakubdyszkiewicz is a code owner automatically assigned from kumahq/kuma-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
release-2.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bartsmykla