Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KUMA_DATAPLANE_DRAIN_TIME to the CP config #2344

Open
bdecoste opened this issue Jul 9, 2021 · 14 comments
Open

Add KUMA_DATAPLANE_DRAIN_TIME to the CP config #2344

bdecoste opened this issue Jul 9, 2021 · 14 comments
Labels
area/envoy area/universal kind/design Design doc or related triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@bdecoste
Copy link
Contributor

bdecoste commented Jul 9, 2021

Summary

Id like to configure universal drain time via the CP config file instead of as an ENV to kuma-dp. i.e. add KUMA_DATAPLANE_DRAIN_TIME param to https://github.com/kumahq/kuma/blob/master/pkg/config/app/kuma-cp/kuma-cp.defaults.yaml
@lahabana lahabana added area/universal triage/pending This issue will be looked at on the next triage meeting and removed universal labels Nov 22, 2021
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 31, 2021
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana added area/envoy kind/design Design doc or related triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting triage/stale Inactive for some time. It will be triaged again labels Feb 7, 2022
@lobkovilya
Copy link
Contributor

I think if we implement the issue #3756 as it states in the description, then it will be possible to send drain_time from Kuma CP to DPP.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Mar 12, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label May 30, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jun 30, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Jul 5, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Oct 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Oct 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 4, 2023
@jakubdyszkiewicz jakubdyszkiewicz removed the triage/stale Inactive for some time. It will be triaged again label Jan 13, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Apr 14, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label May 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Aug 2, 2023
@bartsmykla bartsmykla removed the triage/stale Inactive for some time. It will be triaged again label Aug 8, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Nov 9, 2023
@jakubdyszkiewicz
Copy link
Contributor

this would require passing drain time in BootstrapResponse#KumaSidecarConfiguration

@jakubdyszkiewicz jakubdyszkiewicz removed the triage/stale Inactive for some time. It will be triaged again label Nov 9, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka
Copy link
Contributor

slonka commented Feb 9, 2024

still the case

kuma/pkg/xds/bootstrap/types/bootstrap_response.go

Line 19 in b44604a

type KumaSidecarConfiguration struct {

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label Feb 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 10, 2024
@bartsmykla bartsmykla removed the triage/stale Inactive for some time. It will be triaged again label May 14, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Aug 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/envoy area/universal kind/design Design doc or related triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@bdecoste @lahabana @slonka @jakubdyszkiewicz @bartsmykla @lobkovilya @lukidzi