Skip to content

nrt-api: Update publishing-bot rules.yaml #110629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

swatisehgal
Copy link
Contributor

@swatisehgal swatisehgal commented Jun 16, 2022

rules.yaml captures the dependencies of code in the staging repo and is used by
the publishing-bot to publish the staging repository.

Signed-off-by: Swati Sehgal [email protected]

What type of PR is this?

Updates publishing-bot rules to ensure noderesourcetopology-api staging repo is published.

/kind cleanup

What this PR does / why we need it:

Depends on #110252. This change is to ensure that testing in CI (specifically the pull-publishing-bot-validate test) runs with the right rules.yaml configuration.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Please refer to this comment for context.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 16, 2022
@k8s-ci-robot
Copy link
Contributor

@swatisehgal: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 16, 2022
@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Jun 16, 2022
@k8s-ci-robot k8s-ci-robot requested a review from sttts June 16, 2022 22:00
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 16, 2022
@swatisehgal
Copy link
Contributor Author

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims June 16, 2022 22:59
@swatisehgal
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 16, 2022
@dims
Copy link
Member

dims commented Jun 17, 2022

@swatisehgal the other one has to merge first then this one.

@swatisehgal
Copy link
Contributor Author

@swatisehgal the other one has to merge first then this one.

Thanks @dims for clarifying this. I might have misunderstood earlier but all good now. Both the PRs (and their description) have been updated.

@swatisehgal swatisehgal force-pushed the publishingbot-rules-update-for-nrtapi branch from 9ff5f1e to aa9bbdc Compare June 28, 2022 11:59
recursive-delete-patterns:
- BUILD
- '*/BUILD'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that chunk intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think this was a mistake. Let me fix it. Thanks for that @kad.

@dims
Copy link
Member

dims commented Aug 23, 2022

Are we picking this up in 1.26 @swatisehgal ?

@swatisehgal
Copy link
Contributor Author

Are we picking this up in 1.26 @swatisehgal ?

Yep, that's the plan. Will polish this in the coming days.

rules.yaml captures the dependencies of the repo and is used by
the publishing-bot to publish the staging repository.

Signed-off-by: Swati Sehgal <[email protected]>
@swatisehgal swatisehgal force-pushed the publishingbot-rules-update-for-nrtapi branch from aa9bbdc to 17db4c1 Compare August 25, 2022 13:34
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swatisehgal
Once this PR has been reviewed and has the lgtm label, please assign nikhita for approval by writing /assign @nikhita in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@swatisehgal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-publishing-bot-validate 17db4c1 link false /test pull-publishing-bot-validate
pull-kubernetes-verify 17db4c1 link true /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@swatisehgal
Copy link
Contributor Author

swatisehgal commented Aug 25, 2022

The failures in CI are because this PR depends on #110252. These should get resolved once the aforementioned PR is merged.

@k8s-ci-robot
Copy link
Contributor

@swatisehgal: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2022
@swatisehgal
Copy link
Contributor Author

/close

as this was merged in #110252.

@k8s-ci-robot
Copy link
Contributor

@swatisehgal: Closed this PR.

In response to this:

/close

as this was merged in #110252.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants