-
Notifications
You must be signed in to change notification settings - Fork 41.2k
nrt-api: Update publishing-bot rules.yaml #110629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nrt-api: Update publishing-bot rules.yaml #110629
Conversation
@swatisehgal: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @dims |
/sig node |
@swatisehgal the other one has to merge first then this one. |
Thanks @dims for clarifying this. I might have misunderstood earlier but all good now. Both the PRs (and their description) have been updated. |
9ff5f1e
to
aa9bbdc
Compare
recursive-delete-patterns: | ||
- BUILD | ||
- '*/BUILD' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that chunk intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think this was a mistake. Let me fix it. Thanks for that @kad.
Are we picking this up in 1.26 @swatisehgal ? |
Yep, that's the plan. Will polish this in the coming days. |
rules.yaml captures the dependencies of the repo and is used by the publishing-bot to publish the staging repository. Signed-off-by: Swati Sehgal <[email protected]>
aa9bbdc
to
17db4c1
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: swatisehgal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@swatisehgal: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The failures in CI are because this PR depends on #110252. These should get resolved once the aforementioned PR is merged. |
@swatisehgal: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/close as this was merged in #110252. |
@swatisehgal: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rules.yaml captures the dependencies of code in the staging repo and is used by
the publishing-bot to publish the staging repository.
Signed-off-by: Swati Sehgal [email protected]
What type of PR is this?
Updates publishing-bot rules to ensure noderesourcetopology-api staging repo is published.
/kind cleanup
What this PR does / why we need it:
Depends on #110252. This change is to ensure that testing in CI (specifically the pull-publishing-bot-validate test) runs with the right rules.yaml configuration.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Please refer to this comment for context.
Does this PR introduce a user-facing change?