secrets: add a best practices section and API access recommentations #4380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This section attempts to capture some of the best practices around client API access to secrets. Specitically that controllers should avoid list and watch operations in favor of getting specific secrets.
|
lgtm |
chenopis
suggested changes
Aug 1, 2017
|
|
||
| For these reasons `watch` and `list` requests for secrets within a namespace are | ||
| extremely powerful capabilities and should be avoided, since listing secrets allows | ||
| the clients to inspect the values if all secrets in that namespace. The ability to |
There was a problem hiding this comment.
missing word? "...since listing secrets allows the clients to inspect the values if all secrets are in that namespace."
chenopis
approved these changes
Aug 1, 2017
|
Deploy preview processing. Built with commit c5d313e |
steveperry-53
added a commit
that referenced
this pull request
Aug 1, 2017
* secrets: add a best practices section and API access recommentations (#4380) * secrets: add a best practices section and API access recommentations This section attempts to capture some of the best practices around client API access to secrets. Specitically that controllers should avoid list and watch operations in favor of getting specific secrets. * add "are" * update scratch.md for issue #4068 (#4069) * update scratch.md for issue #4068 Issue #4068 details the dangers of recommending single etcd instance. This will likely need to be expanded into better "highly available" cluster documentation * Refactor list style * fix ordered list * fix unordered list * ul * add back shell * Adding tutorial links to docs (#4570) * Adding tutorial links to docs * Update index.md
jesscodez
pushed a commit
that referenced
this pull request
Sep 22, 2017
…4380) * secrets: add a best practices section and API access recommentations This section attempts to capture some of the best practices around client API access to secrets. Specitically that controllers should avoid list and watch operations in favor of getting specific secrets. * add "are"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This section attempts to capture some of the best practices around
client API access to secrets. Specifically that list and watch operations
on secrets are extremely powerful.
This has been expressed a few times, but not formalized:
kubernetes/ingress-nginx#816
kubernetes/kubernetes#45189
kubernetes-retired/service-catalog#621
cc @kubernetes/sig-auth-misc
This change is