KEP-4191 Split Image Filesystem #4198
Conversation
kannon92
commented
Sep 8, 2023
- One-line PR description: KEP for Split Filesystem
- Issue link: Kubelet support for Split Image Filesystem #4191
- Other comments:
|
/sig node |
9fc295e to
736b476
Compare
|
|
||
| - Pods | ||
| - Logs | ||
| - Containers |
There was a problem hiding this comment.
This would require containerd snapshotter to support multi-filesystem, i.e. the top (rw) snapshot being on one fs, and the lower (ro) snapshots being on another.
snapshotter implementations need to be changed to make this happen.
There was a problem hiding this comment.
do you think containerd needs to have support for this to add support in the kubelet to be flexible to handle this? in other words: is it required both CRI be able to do this if the kubelet acts correctly when it's not the case? Then, it could be up to each community on how they want to handle these features
There was a problem hiding this comment.
@mikebrow @ruiwen-zhao wdyt?
We talked a bit about this with @mikebrow and i think there can be interest in this in containerd but it would require some work in containerd. But we could still agree on the CRI api in this KEP.
|
/lgtm |
|
Only one comment about running this feature with container runtime that doesn't have the CRI implementation. But for alpha this looks good. /lgtm |
|
/lgtm |
08d4236 to
0e70ec7
Compare
0e70ec7 to
531c4b5
Compare
|
@dchen1107 I seem to have lost your approval. Can you look this over again? |
|
/lgtm |
531c4b5 to
39707af
Compare
39707af to
14c0960
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, johnbelamaric, kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |