Skip to content

PodResources API for DRA: match API with actual implementation in 1.27 #3915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2023
Merged

PodResources API for DRA: match API with actual implementation in 1.27 #3915

merged 1 commit into from
Jul 10, 2023

Conversation

moshe010
Copy link
Contributor

  • One-line PR description:
    match API with actual implementation in 1.27
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 19, 2023
@k8s-ci-robot k8s-ci-robot requested a review from dchen1107 March 19, 2023 10:54
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Mar 19, 2023
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 19, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @moshe010. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 19, 2023
@moshe010 moshe010 force-pushed the pod-resources-api-update branch from 20e52e2 to 0080ae0 Compare March 19, 2023 11:03
@bart0sh
Copy link
Contributor

bart0sh commented Mar 30, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 30, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Apr 6, 2023

/lgtm
/assign @klueska

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2023
SergeyKanzhelev
SergeyKanzhelev approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

klueska
klueska reviewed Jul 7, 2023
View reviewed changes
keps/sig-node/3695-pod-resources-for-dra/README.md Outdated
Comment on lines 100 to 102
claim name, claim namespace, and a list of claimed resources allocated by a DRA driver.
Currently, claimed resources contains CDI Devices but in future it may extend to
support plugins that allocate different type of resource (not CDI Devices).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
claim name, claim namespace, and a list of claimed resources allocated by a DRA driver.
Currently, claimed resources contains CDI Devices but in future it may extend to
support plugins that allocate different type of resource (not CDI Devices).
claim name, claim namespace, and a list of claimed resources allocated by a DRA driver.
Currently, the claim resources only contain a list of CDI Devices but in the future they may be extended to
support plugins that allocate different types of resource (not just CDI Devices).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@klueska
Copy link
Contributor

klueska commented Jul 7, 2023

Small wording change, otherwise
/lgtm
/approve

@moshe010 moshe010 force-pushed the pod-resources-api-update branch from 0080ae0 to 3e2ad56 Compare July 9, 2023 18:11
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2023
@klueska
Copy link
Contributor

klueska commented Jul 10, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2023
@klueska klueska mentioned this pull request Jul 10, 2023
Open
8 tasks
@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, klueska, moshe010, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1293ffc into kubernetes:master Jul 10, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 10, 2023
@aojea
Copy link
Member

aojea commented Dec 23, 2023 •
edited
Loading

This needs to include sig-network as approvers, we have this debate with accelerator network devices and several proposal on how to do it , it will not be nice if kubernetes ends with two different ways of configuring these devices

/cc @thockin @derekwaynecarr @klueska @dchen1107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@klueska klueska Awaiting requested review from klueska

@thockin thockin Awaiting requested review from thockin

Assignees

@klueska klueska

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
7 participants
@moshe010 @k8s-ci-robot @bart0sh @klueska @dchen1107 @aojea @SergeyKanzhelev