Skip to content

KEP 3063: Update to reflect changes merged into v1.27 #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

klueska
Copy link
Contributor

@klueska klueska commented Jan 31, 2023

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jan 31, 2023
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2023
@klueska klueska force-pushed the KEP-3063-update-kubelet-plugin-config branch from 17128af to 36c3192 Compare January 31, 2023 14:59
@bart0sh
Copy link
Contributor

bart0sh commented Jan 31, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Jan 31, 2023

/assign @kad @pohly

@kad
Copy link
Member

kad commented Feb 3, 2023

I might ask maybe silly question, but what prevents drivers to open multiple connections to kubelet and dynamically register/unregister under different names? yes, it is several connections, but probably would be simpler than separate watch interface.

@klueska
Copy link
Contributor Author

klueska commented Feb 3, 2023

I might ask maybe silly question, but what prevents drivers to open multiple connections to kubelet and dynamically register/unregister under different names? yes, it is several connections, but probably would be simpler than separate watch interface.

We are scratching the whole idea of this interface in favor of what’s explained in the comment above. I’ll rework the PR next week.

@klueska klueska changed the title KEP 2063: Extend with a WatchConfiguration API for the kubelet plugin KEP 2063: Extend ResourceClaimStatus with a slice of AllocationResults Feb 10, 2023
@klueska klueska force-pushed the KEP-3063-update-kubelet-plugin-config branch from 36c3192 to 81833f2 Compare February 10, 2023 11:12
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2023
@klueska
Copy link
Contributor Author

klueska commented Feb 10, 2023

Updated based on our discussion in #3802 (comment)

@pohly
Copy link
Contributor

pohly commented Feb 10, 2023

/retitle KEP 3063: Extend ResourceClaimStatus with a slice of AllocationResults

@k8s-ci-robot k8s-ci-robot changed the title KEP 2063: Extend ResourceClaimStatus with a slice of AllocationResults KEP 3063: Extend ResourceClaimStatus with a slice of AllocationResults Feb 10, 2023
@klueska klueska force-pushed the KEP-3063-update-kubelet-plugin-config branch from 81833f2 to b0b66ca Compare February 14, 2023 13:45
@kad
Copy link
Member

kad commented Feb 15, 2023

For me, current proposal for solving that problem, looks good.

@bart0sh
Copy link
Contributor

bart0sh commented Feb 16, 2023

small nit, otherwise lgtm

@klueska klueska force-pushed the KEP-3063-update-kubelet-plugin-config branch from b0b66ca to d9c9673 Compare February 16, 2023 11:31
klueska added a commit to klueska/kubernetes that referenced this pull request Mar 14, 2023
This implements the change outlined in the following KEP update:
kubernetes/enhancements#3802

Signed-off-by: Kevin Klues <[email protected]>
k8s-publishing-bot pushed a commit to kubernetes/api that referenced this pull request Mar 15, 2023
For Kubernetes 1.27, we intend to make some breaking API changes:
- rename PodScheduling -> PodSchedulingHints (kubernetes/kubernetes#114283)
- extend ResourceClaimStatus (kubernetes/enhancements#3802)

We need to switch from v1alpha1 to v1alpha2 for that.

Kubernetes-commit: 29941b8d3e7928244f48b05bf5bd453221fe7a9d
k8s-publishing-bot pushed a commit to kubernetes/api that referenced this pull request Mar 15, 2023
This implements the change outlined in the following KEP update:
kubernetes/enhancements#3802

Signed-off-by: Kevin Klues <[email protected]>

Kubernetes-commit: 53dda4ffe21c1dd72f2264fd9fadbf7b5e33ded9
k8s-publishing-bot pushed a commit to kubernetes/client-go that referenced this pull request Mar 15, 2023
For Kubernetes 1.27, we intend to make some breaking API changes:
- rename PodScheduling -> PodSchedulingHints (kubernetes/kubernetes#114283)
- extend ResourceClaimStatus (kubernetes/enhancements#3802)

We need to switch from v1alpha1 to v1alpha2 for that.

Kubernetes-commit: 29941b8d3e7928244f48b05bf5bd453221fe7a9d
k8s-publishing-bot pushed a commit to kubernetes/dynamic-resource-allocation that referenced this pull request Mar 15, 2023
For Kubernetes 1.27, we intend to make some breaking API changes:
- rename PodScheduling -> PodSchedulingHints (kubernetes/kubernetes#114283)
- extend ResourceClaimStatus (kubernetes/enhancements#3802)

We need to switch from v1alpha1 to v1alpha2 for that.

Kubernetes-commit: 29941b8d3e7928244f48b05bf5bd453221fe7a9d
@klueska klueska force-pushed the KEP-3063-update-kubelet-plugin-config branch from f400871 to b0c1a43 Compare April 11, 2023 09:30
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 11, 2023
@klueska klueska changed the title KEP 3063: Extend ResourceClaimStatus with a slice of AllocationResults KEP 3063: Update to reflect changes merged into v1.27 Apr 11, 2023
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Apr 11, 2023

/lgtm

@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, klueska, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit d1b916c into kubernetes:master Apr 11, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 11, 2023
rayowang pushed a commit to rayowang/kubernetes that referenced this pull request Feb 9, 2024
For Kubernetes 1.27, we intend to make some breaking API changes:
- rename PodScheduling -> PodSchedulingHints (kubernetes#114283)
- extend ResourceClaimStatus (kubernetes/enhancements#3802)

We need to switch from v1alpha1 to v1alpha2 for that.
rayowang pushed a commit to rayowang/kubernetes that referenced this pull request Feb 9, 2024
This implements the change outlined in the following KEP update:
kubernetes/enhancements#3802

Signed-off-by: Kevin Klues <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

9 participants