-
Notifications
You must be signed in to change notification settings - Fork 1.6k
KEP 3063: Update to reflect changes merged into v1.27 #3802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP 3063: Update to reflect changes merged into v1.27 #3802
Conversation
17128af
to
36c3192
Compare
/lgtm |
I might ask maybe silly question, but what prevents drivers to open multiple connections to kubelet and dynamically register/unregister under different names? yes, it is several connections, but probably would be simpler than separate watch interface. |
We are scratching the whole idea of this interface in favor of what’s explained in the comment above. I’ll rework the PR next week. |
36c3192
to
81833f2
Compare
Updated based on our discussion in #3802 (comment) |
/retitle KEP 3063: Extend ResourceClaimStatus with a slice of AllocationResults |
81833f2
to
b0b66ca
Compare
For me, current proposal for solving that problem, looks good. |
small nit, otherwise lgtm |
b0b66ca
to
d9c9673
Compare
This implements the change outlined in the following KEP update: kubernetes/enhancements#3802 Signed-off-by: Kevin Klues <[email protected]>
For Kubernetes 1.27, we intend to make some breaking API changes: - rename PodScheduling -> PodSchedulingHints (kubernetes/kubernetes#114283) - extend ResourceClaimStatus (kubernetes/enhancements#3802) We need to switch from v1alpha1 to v1alpha2 for that. Kubernetes-commit: 29941b8d3e7928244f48b05bf5bd453221fe7a9d
This implements the change outlined in the following KEP update: kubernetes/enhancements#3802 Signed-off-by: Kevin Klues <[email protected]> Kubernetes-commit: 53dda4ffe21c1dd72f2264fd9fadbf7b5e33ded9
For Kubernetes 1.27, we intend to make some breaking API changes: - rename PodScheduling -> PodSchedulingHints (kubernetes/kubernetes#114283) - extend ResourceClaimStatus (kubernetes/enhancements#3802) We need to switch from v1alpha1 to v1alpha2 for that. Kubernetes-commit: 29941b8d3e7928244f48b05bf5bd453221fe7a9d
For Kubernetes 1.27, we intend to make some breaking API changes: - rename PodScheduling -> PodSchedulingHints (kubernetes/kubernetes#114283) - extend ResourceClaimStatus (kubernetes/enhancements#3802) We need to switch from v1alpha1 to v1alpha2 for that. Kubernetes-commit: 29941b8d3e7928244f48b05bf5bd453221fe7a9d
Signed-off-by: Kevin Klues <[email protected]>
f400871
to
b0c1a43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, klueska, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For Kubernetes 1.27, we intend to make some breaking API changes: - rename PodScheduling -> PodSchedulingHints (kubernetes#114283) - extend ResourceClaimStatus (kubernetes/enhancements#3802) We need to switch from v1alpha1 to v1alpha2 for that.
This implements the change outlined in the following KEP update: kubernetes/enhancements#3802 Signed-off-by: Kevin Klues <[email protected]>
One-line PR description: Update KEP to reflect changes merged into v1.27
PRs for changes: