Go Structs for GEP-91

[arkodg]

/kind documentation
/kind feature
/kind gep

What this PR does / why we need it:

Takes #2759 forward and implements the go structs described in GEP-91 https://gateway-api.sigs.k8s.io/geps/gep-91/

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Adds support for a new FrontendValidation field with the Gateway Listener TLS field to support validation of client certificates using a CA Certificate as a trust anchor

[arkodg]

cc @robscott

[robscott]

Thanks @arkodg! This mostly LGTM, just looks like some codegen issues in presubmit.

[arkodg]

/retest

[arkodg]

not seeing any failures when running ./hack/verify-all.sh -v locally
except for this one, unsure how its related to this PR

Verifying docker images
./hack/../hack/verify-docker-build.sh: line 25: BUILDX_CONTEXT: unbound variable
Test FAILED: ./hack/../hack/verify-docker-build.sh 

[robscott]

@arkodg I tried running hack/update-codegen.sh from your PR and ended up with changes to a couple generated GRPC pb files:

diff --git a/conformance/echo-basic/grpcechoserver/grpcecho.pb.go b/conformance/echo-basic/grpcechoserver/grpcecho.pb.go
index 81135b30..9585b776 100644
--- a/conformance/echo-basic/grpcechoserver/grpcecho.pb.go
+++ b/conformance/echo-basic/grpcechoserver/grpcecho.pb.go
@@ -14,7 +14,7 @@

 // Code generated by protoc-gen-go. DO NOT EDIT.
 // versions:
-//     protoc-gen-go v1.28.0
+//     protoc-gen-go v1.28.1
 //     protoc        v4.22.2
 // source: grpcecho.proto

diff --git a/conformance/echo-basic/grpcechoserver/grpcecho_grpc.pb.go b/conformance/echo-basic/grpcechoserver/grpcecho_grpc.pb.go
index 67d46680..f367cb66 100644
--- a/conformance/echo-basic/grpcechoserver/grpcecho_grpc.pb.go
+++ b/conformance/echo-basic/grpcechoserver/grpcecho_grpc.pb.go
@@ -1,4 +1,8 @@
 // Code generated by protoc-gen-go-grpc. DO NOT EDIT.
+// versions:
+// - protoc-gen-go-grpc v1.2.0
+// - protoc             v4.22.2
+// source: grpcecho.proto

 package grpcechoserver

@@ -11,6 +15,7 @@ import (

 // This is a compile-time assertion to ensure that this generated file
 // is compatible with the grpc package it is being compiled against.
+// Requires gRPC-Go v1.32.0 or later.
 const _ = grpc.SupportPackageIsVersion7

 // GrpcEchoClient is the client API for GrpcEcho service.
@@ -95,8 +100,8 @@ type UnsafeGrpcEchoServer interface {
        mustEmbedUnimplementedGrpcEchoServer()
 }

-func RegisterGrpcEchoServer(s *grpc.Server, srv GrpcEchoServer) {
-       s.RegisterService(&_GrpcEcho_serviceDesc, srv)
+func RegisterGrpcEchoServer(s grpc.ServiceRegistrar, srv GrpcEchoServer) {
+       s.RegisterService(&GrpcEcho_ServiceDesc, srv)
 }

 func _GrpcEcho_Echo_Handler(srv interface{}, ctx context.Context, dec func(interface{}) error, interceptor grpc.UnaryServerInterceptor) (interface{}, error) {
@@ -153,7 +158,10 @@ func _GrpcEcho_EchoThree_Handler(srv interface{}, ctx context.Context, dec func(
        return interceptor(ctx, in, info, handler)
 }

-var _GrpcEcho_serviceDesc = grpc.ServiceDesc{
+// GrpcEcho_ServiceDesc is the grpc.ServiceDesc for GrpcEcho service.
+// It's only intended for direct use with grpc.RegisterService,
+// and not to be introspected or modified (even as a copy)
+var GrpcEcho_ServiceDesc = grpc.ServiceDesc{
        ServiceName: "gateway_api_conformance.echo_basic.grpcecho.GrpcEcho",
        HandlerType: (*GrpcEchoServer)(nil),
        Methods: []grpc.MethodDesc{
~
~
~

I think that would resolve the failing presubmit, I'm guessing you're not seeing the same diff when you run codegen?

[arkodg]

ha thanks @robscott !

bumping protoc-gen-go & protoc-gen-go-grpc did the trick

go install google.golang.org/protobuf/cmd/[email protected]
go install google.golang.org/grpc/cmd/[email protected]

do we have a philosophy on how we pin dev tools in this project ? for e.g. in some projects these tools are prefetched and saved in a local tools/bin dir to ensure tooling consistency (and use dependabot to keep bumping them ) for all,

[robscott]

Oh good catch, thanks!

do we have a philosophy on how we pin dev tools in this project ? for e.g. in some projects these tools are prefetched and saved in a local tools/bin dir to ensure tooling consistency (and use dependabot to keep bumping them ) for all,

We do have this for roughly that purpose, we should probably add those dependencies to pkg/tools to ensure we're all on the same version (cc @gnossen in case I'm missing something):

gateway-api/tools/tools.go

Lines 25 to 34 in c57c131

	import (
	_ "github.com/ahmetb/gen-crd-api-reference-docs"
	_ "k8s.io/code-generator/cmd/client-gen"
	_ "k8s.io/code-generator/cmd/deepcopy-gen"
	_ "k8s.io/code-generator/cmd/informer-gen"
	_ "k8s.io/code-generator/cmd/lister-gen"
	_ "k8s.io/code-generator/cmd/register-gen"
	_ "sigs.k8s.io/controller-runtime/pkg/scheme"
	_ "sigs.k8s.io/controller-tools/cmd/controller-gen"
	)

[robscott]

Thanks @arkodg!

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [robscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaneutt]

After existing comments are resolved, this generally LGTM to me.

/lgtm

But hold just so it doesn't immediately merge.

/hold

[robscott]

@arkodg looks like another PR beat this one in, will LGTM once you rebase.

/hold cancel

[robscott]

Thanks @arkodg!

/lgtm