Skip to content

callback option has a weird signature #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ExplodingCabbage opened this issue Jan 8, 2024 · 0 comments · Fixed by #490
Closed

callback option has a weird signature #462

ExplodingCabbage opened this issue Jan 8, 2024 · 0 comments · Fixed by #490

Comments

@ExplodingCabbage
Copy link
Collaborator

The diffing functions take a (currently undocumented) callback option. If provided, the diff is calculated in async mode and the result is passed as the second argument to the callback function.

Unless I'm missing something, the first argument is just... never provided. It's always undefined, whether the diff is calculated successfully or not.

This seems pretty bizarre. We should just eliminate the first argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant