Make xcpp*/kernel.json.in subsitution more portable #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html CMAKE_INSTALL_BINDIR can be either absolute or relative. Make sure we use the absolute value through CMAKE_INSTALL_FULL_BINDIR.
|
this is a wip, I still need to sort out a few thing, please wait before considering reviewing this PR |
|
no longer a wip, feel free to review :-) |
|
I can't find a reference to |
|
here you have documentation for the generic |
Great, then we should go ahead and make the fix in all xeus-based kernels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html
CMAKE_INSTALL_BINDIR can be either absolute or relative. Make sure we use the absolute value through CMAKE_INSTALL_FULL_BINDIR.