Fix .offset() and .position() bugs #3487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gibson042, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jbedard, @markelog and @dgalvez to be potential reviewers. |
This was referenced Jan 5, 2017
Open
gibson042
commented
Jan 5, 2017
| // TODO Verify .offset(...) | ||
| // assert.deepEqual( $el.offset( offset ).offset(), offset ) | ||
| // assert.deepEqual( $el.offset( adjustedOffset ).offset(), adjustedOffset ) | ||
| // assert.deepEqual( $new.offset( offset ).offset(), offset ) |
There was a problem hiding this comment.
Omitted for scope creep. See gh-3488.
|
Resolved: There's no need to handle extreme situations in the broken environments. |
|
I think we need perf test for it |
|
A perf test for what? I'm not aware of any alternatives here. |
7ff4e83 to
a48fed8
Compare
gibson042
added a commit
to gibson042/api.jquery.com
that referenced
this pull request
Mar 20, 2017
|
@jquery/core This one is finally ready to land. I opened jquery/api.jquery.com#1027 to clarify some details that came to light over the course of working on it. |
gibson042
added a commit
to jquery/api.jquery.com
that referenced
this pull request
Apr 25, 2017
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes
.offset()always relative to the document and.position()always relative to the closest containing block offsetParent (if any).Some new tests fail on IE<11 (where
document.documentElement.getBoundingClientRect()erroneously includes margins and disregards viewport scrolling), and have been manually disabled/patched up.Fixes gh-3080
Fixes gh-3107
Closes gh-3096
Ref gh-3479
Checklist