[5.3] Fixed manual Unblock sets user as Activated (Verified) issue

[Amitesh007z]

Pull Request for Issue #45063 .

Summary of Changes:

This PR fixes an issue where manually unblocking a user does not set them as Activated (Verified). Previously, when an admin unblocked a user, the activation state remained unchanged, which could cause login issues. This fix ensures that when an admin unblocks a user, their activation status is also updated to Verified.

Testing Instructions

Testing Instructions
Log in to the Joomla administrator panel.
Navigate to Users → Manage Users.
Now new create account ,
traverse back to manage users panel and check unblocking (it must eventually activate respective user which happens when the same user verifies mail and admin verifies mail)

Actual result BEFORE applying this Pull Request

above image is result of manual unblock by admin where activation is red

---

above image is result of other method i.e through mail verification of user and admin .

Expected result AFTER applying this Pull Request

on manual click on unblock (i.e manually unblocking), gives green to activation too, which results in consistency.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[brianteeman]

Your assumptions are wrong.

If the site is set to no verfication then the user is marked as activated on registration

As stated before - until all the possible registration scenarios are documented it is not a good idea to change anything here

[Amitesh007z]

Your assumptions are wrong.

If the site is set to no verfication then the user is marked as activated on registration

As stated before - until all the possible registration scenarios are documented it is not a good idea to change anything here

Hi @brianteeman sir,
I’ve made the changes to address the inconsistency as instructed by MacJoom while ensuring the registration process remains unaffected sir . I really appreciate your guidance on this sir . Please let me know if there’s anything I might have missed or if further adjustments are needed sir . Happy to make any necessary changes

[Amitesh007z]

@richard67
i would be happy to hear further review and feedback sir , also further steps to be done sir

[crimle]

The Summary of Changes looks very structured and clear. Compliments and many thanks for this. Not all PRs are so well documented, which makes it often difficult for testers to get the perspective.

I am the person who originally reported this issue. But I am afraid, my request was somewhat misunderstood. My concern is NOT about the manual addition of users by the administrator. I wanted to discuss whether the user registration process should be improved in case the option ‘New User Account Activation’ is set to ’Administrator’.

IS

• A user registers for a new account
• He clicks the verification link in the email he receives
• This action does not change the state of the two icons, neither «Enabled» nor «Activated». Literally speaking this is correct, since the user only has verified his email address, but not activated his account. Keep in mind that the option ‘New User Account Activation’ is set to ’Administrator’.

MY PROPOSAL

• A user registers for a new account
• He clicks the verification link in the email he receives
• This action should change the state of the second of these icons. This allows the administrator to determine that the account has been verified. Otherwise he would have to guess the verification status from the fact, that he has received a notification email from the new user account.
• My proposal would make it necessary that the column's heading is renamed from «Activated» to «Verified».

Summarising I would think, that my propsal would make the whole user registration and approval process more transparent and clear then it was until now.

BY NO MEANS is it necessary, to completely rewrite this function from the scratch. It basically works, but could be clarified a little bit.

[Amitesh007z]

As stated before - until all the possible registration scenarios are documented it is not a good idea to change anything here

Thank you for the clarification and the detailed explanation of your proposal sir . I now better understand that your concern is specifically about improving transparency in the ‘New User Account Activation: Administrator’ scenario rather than manual user addition.

I also acknowledge the importance of fully documenting all possible registration scenarios before making any changes, as suggested by @brianteeman . To move forward productively, would it be helpful if I first work on a draft documentation of the different registration scenarios, including the current behavior and potential improvements?

Once we have a well-structured document covering all cases, we could then reassess whether the proposed change aligns with Joomla’s existing logic and best practices. Please let me know if this approach makes sense or if there are any specific guidelines I should follow for documenting these scenarios.

Looking forward to your thoughts sir

[crimle]

@Amitesh007z I appreciate very much your suggestion «draft documentation of the different registration scenarios, including the current behavior and potential improvements». Maybe there already exists a documentation? Or am I the one who should work on this?

[Amitesh007z]

@Amitesh007z I appreciate very much your suggestion «draft documentation of the different registration scenarios, including the current behavior and potential improvements». Maybe there already exists a documentation? Or am I the one who should work on this?

In mattermost chat ,Mr.Emmanuel L. asked me to check once in https://manual.joomla.org/ for any documentation,
I can start looking into Joomla’s official documentation and any related discussions to see if this has already been documented. If nothing comprehensive exists, I’d be happy to contribute by drafting a structured document outlining the current behavior and potential improvements, If you happen to know of any references or previous discussions that might be useful as a starting point? That would definitely help in making sure we don’t miss any important details sir

Looking forward to your thoughts sir

[crimle]

@Amitesh007z Very good :-) I would be happy to review your documentation at the appropriate time. Please let me know when you are ready.

[crimle]

@Amitesh007z Any progress with the documentation yet? I look forward to reviewing your documentation at the appropriate time. Please let me know when you are ready.

[Amitesh007z]

@Amitesh007z Any progress with the documentation yet? I look forward to reviewing your documentation at the appropriate time. Please let me know when you are ready.

@crimle , yes sir its already done , just formatting is to be done , will share the draft now sir , Sorry for the delay

[Amitesh007z]

@Amitesh007z Any progress with the documentation yet? I look forward to reviewing your documentation at the appropriate time. Please let me know when you are ready.

@crimle
Joomla User Registration Scenarios Documentation.docx

This document outlines the possible user registration processes in Joomla and includes a summary table at the end to compare different registration types sir . I would appreciate your feedback on any improvements or corrections needed. Looking forward to your thoughts sir , Thanks in advance ,

Also sir ,On making this , I noticed a discrepancy in the Admin-User Activation process is that email activation is not utilized, as the Enabled and Activated statuses are solely controlled by the admin. I think there is an inconsistency on this activation logic compared to others . Would be happy to hear your thoughts sir ,

Sorry for the delay sir
Thanks