[5.3] Fix item count does not take access level into account #44950

janschoenherr · 2025-02-21T09:07:03Z

Currently when getting the item count of a category, the access level is not being taken into account. This PR fixes the issue.

Summary of Changes

Add the access condition to the item subquery.

Testing Instructions

Create a menu item of type List All Categories in an Article Category Tree.

If you navigate to the menu item, it should display a list of categories with an article count.

Have at least one article in one of the categories restricted by its access level. Make sure you are not logged in.

Actual result BEFORE applying this Pull Request

The access restricted article is being included in the article count.
The Articles > Unauthorized Links option has no effect on the article count.

Expected result AFTER applying this Pull Request

The access restricted article is not being included in the item count.

If however Articles > Unauthorized Links option is set to Yes the access restricted article is included.

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed

ghost · 2025-02-21T12:08:10Z

@janschoenherr I think the test instructions belong to the new Articles-module? If so i didn't find where the "Article Count" to set. If not, can you please be more specific in the test instructions?

janschoenherr · 2025-02-21T13:31:52Z

@janschoenherr I think the test instructions belong to the new Articles-module? If so i didn't find where the "Article Count" to set. If not, can you please be more specific in the test instructions?

I updated the testing instructions.

ghost · 2025-02-21T16:31:25Z

I have tested this item ✅ successfully on dd5e3b4

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44950.}

viocassel · 2025-02-21T20:19:04Z

I have tested this item ✅ successfully on dd5e3b4

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44950.}

brianteeman · 2025-02-21T22:10:48Z

I have tested this item 🔴 unsuccessfully on dd5e3b4

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44950.}

brianteeman · 2025-02-21T22:21:02Z

This doesnt take into account what happens when you have unauthorised links set to yes

Before the PR the menu item would display the total number of articles and then when entered the category will display the intro text of the registered articles to guest users

After the PR the menu item only displays the public number of articles which if greater than 0 will still display the intro text of the registered articles to guest users. If the number of public articles in the category is 0 then the category will not be displayed at all.

See video

After PR

chrome_RAEUI9rGdb.mp4

Before PR

chrome_04rbtN0569.mp4

brianteeman · 2025-02-21T22:21:52Z

There are probably other areas negatively impacted by this change - this was just the first one that came to mind

janschoenherr · 2025-02-24T09:05:27Z

I have added a new option accessOnItems to resolve that.

janschoenherr · 2025-02-24T09:53:36Z

$params = (clone $this->getState('params'))->merge($params);

This actually fixes another bug. Just evaluating the menu params, doesn't take the global component parameters into account. e.g. Use Global (hide) Which might lead to fetching countItems unnecessarily.

ghost · 2025-02-26T06:35:58Z

@janschoenherr Can you update the test instructions including the #44950 (comment) by @brianteeman and your comment?

This actually fixes another bug. Just evaluating the menu params, doesn't take the global component parameters into account. e.g. Use Global (hide) Which might lead to fetching countItems unnecessarily.

janschoenherr · 2025-02-26T12:37:54Z

This actually fixes another bug. Just evaluating the menu params, doesn't take the global component parameters into account. e.g. Use Global (hide) Which might lead to fetching countItems unnecessarily.

Regarding my additional comment:

You'll have to enable Debug System.

Then set Empty Categories to Show and # Articles in Category to Hide

in the Global Configuration.

Without the fix, the numItems are still queried:

With the fix, they are not:

ghost · 2025-02-26T15:32:37Z

I have tested this item ✅ successfully on 5085b03

Unauthorised Links `No`

2-no-unauthorised-articlespublicorunauthorised

Unauthorised Links `Yes`

2-unauthorised-articlespublicorunauthorised

The categories All articles are public show 7 articles and No articles show no articles. No difference what value Unauthorised Links is set.
Category No articles isn't shown in menu item type List All Categories in an Article Category Tree.
Register to read more … works as expected.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44950.}

libraries/src/Categories/Categories.php

exlemor · 2025-03-17T00:49:43Z

I have tested this item ✅ successfully on 24db2a0

I have tested this successfully. :)

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44950.}

ghost · 2025-03-17T05:20:08Z

I have tested this item ✅ successfully on 24db2a0

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44950.}

joomdonation · 2025-03-17T05:26:15Z

libraries/src/Categories/Categories.php

+        $options['access']        = $options['access'] ?? 'true';
+        $options['published']     = $options['published'] ?? 1;
+        $options['countItems']    = $options['countItems'] ?? 0;
+        $options['accessOnItems'] = $options['accessOnItems'] ?? true;


I haven't checked the details but there are potential issues here. You enable accessOnItems by default, so it will:

Change the previous behavior

If the items table does not have access field, it will cause SQL error.

I enabled it by default, because 'access' is enabled by default too and otherwise we'd have to change all places, where this is called (That's possible too, of course). I believe all relevant Joomla tables have an access field. But yes, if you have a 3rd party extension without the access field on the item table, it might break.

Better be safe. We could not know what people do with their own code.

Okay, I updated the PR to default enable it for core extensions only.

exlemor · 2025-03-17T23:02:26Z

@janschoenherr - now when I try to test, we have a regression possibly, the results are the same with and without the PR - unlike in my previous test where things were different and matching the aim of the PR (filtering out the item count).... FYI.

exlemor · 2025-03-18T12:54:31Z

@janschoenherr yes, I am using a menu item of type List All Categories in an Article Category Tree... I just retested it, 1 minute ago and still same reaction - the numbers do not move, if need be, I can make a video...

janschoenherr · 2025-03-18T13:30:47Z

@exlemor Thanks for testing. Did you set the 'Unauthorised Links' option in Articles to No?

exlemor · 2025-03-18T14:34:54Z

@exlemor Thanks for testing. Did you set the 'Unauthorised Links' option in Articles to No?

With Unauthorized Links set to No or Yes, same results with none of the numbers changing ;(
(I cleared cache after each change just in case).

janschoenherr · 2025-03-18T15:53:33Z

And you are not logged-in in the frontend, right?

exlemor · 2025-03-18T17:45:19Z

And you are not logged-in in the frontend, right?

Definitely only logged into the backend. Not the front-end.

exlemor · 2025-03-18T18:32:25Z

@janschoenherr - Could the issue be that I set those articles to Special and Super Users vs Registered or Publisher etc?

Just changed one of the articles from Special to Registered and it didn't work either ;( - sorry.

krishnaGandhi11 · 2025-03-18T19:43:24Z

I have tested this item ✅ successfully on 0ed6a90

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44950.}

krishnaGandhi11 · 2025-03-18T19:47:09Z

I have tested this item ✅ successfully on 0ed6a90

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44950.

Here's a before-and-after look at the results of this PR!

PR.-.44950.2.1.mp4

janschoenherr · 2025-04-07T08:03:40Z

@exlemor I rebased the PR to 5.3 now. Thanks for looking into it!

QuyTon · 2025-04-07T13:57:05Z

Please fix phpcs: https://ci.joomla.org/joomla/joomla-cms/83956/1/7

exlemor · 2025-04-07T21:51:06Z

I have tested this item ✅ successfully on cc910c8

I have tested this successfully this time :D.

@janschoenherr (sorry it took me so long to re-test this).

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44950.}

janschoenherr · 2025-04-08T15:32:05Z

Thanks for testing again!

libraries/src/Categories/Categories.php

Linkedla · 2025-04-24T19:08:07Z

I have tested this item ✅ successfully on 5aabb98

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44950.}

joomla-cms-bot added the PR-5.2-dev label Feb 21, 2025

janschoenherr force-pushed the patch-30 branch 2 times, most recently from f9af518 to dd5e3b4 Compare February 21, 2025 09:36

janschoenherr force-pushed the patch-30 branch from dd5e3b4 to 02e35d0 Compare February 24, 2025 08:51

janschoenherr force-pushed the patch-30 branch from 02e35d0 to 5085b03 Compare February 24, 2025 09:19

QuyTon reviewed Feb 26, 2025

View reviewed changes

libraries/src/Categories/Categories.php Outdated Show resolved Hide resolved

joomdonation reviewed Mar 17, 2025

View reviewed changes

janschoenherr force-pushed the patch-30 branch from 24db2a0 to 4552f0c Compare March 17, 2025 09:48

janschoenherr requested review from laoneo, chmst, bembelimen, HLeithner, rdeutz and Hackwar as code owners March 17, 2025 09:48

joomla-cms-bot added the Unit/System Tests label Mar 17, 2025

janschoenherr force-pushed the patch-30 branch from 4552f0c to 0994d96 Compare March 17, 2025 09:52

joomla-cms-bot removed the Unit/System Tests label Mar 17, 2025

janschoenherr force-pushed the patch-30 branch from 0994d96 to 0ed6a90 Compare March 18, 2025 11:59

janschoenherr force-pushed the patch-30 branch from 0ed6a90 to c82ae86 Compare April 7, 2025 08:00

joomla-cms-bot added the Unit/System Tests label Apr 7, 2025

janschoenherr changed the base branch from 5.2-dev to 5.3-dev April 7, 2025 08:02

janschoenherr changed the title ~~[5.2] Fix item count does not take access level into account~~ [5.3] Fix item count does not take access level into account Apr 7, 2025

joomla-cms-bot added PR-5.3-dev and removed Unit/System Tests labels Apr 7, 2025

[5.3] Fix item count does not take access level into account

cc910c8

janschoenherr force-pushed the patch-30 branch from c82ae86 to cc910c8 Compare April 7, 2025 16:14

QuyTon reviewed Apr 9, 2025

View reviewed changes

libraries/src/Categories/Categories.php Outdated Show resolved Hide resolved

QuyTon and others added 3 commits April 9, 2025 08:58

Update libraries/src/Categories/Categories.php

43ed4f4

Added space before and after .

324338c

Merge branch '5.3-dev' into patch-30

5aabb98

exlemor removed the PR-5.2-dev label Apr 28, 2025

Uh oh!

[5.3] Fix item count does not take access level into account #44950

Are you sure you want to change the base?

[5.3] Fix item count does not take access level into account #44950

Conversation

janschoenherr commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Uh oh!

ghost commented Feb 21, 2025

Uh oh!

janschoenherr commented Feb 21, 2025

Uh oh!

ghost commented Feb 21, 2025

Uh oh!

viocassel commented Feb 21, 2025

Uh oh!

brianteeman commented Feb 21, 2025

Uh oh!

brianteeman commented Feb 21, 2025

After PR

Before PR

Uh oh!

brianteeman commented Feb 21, 2025

Uh oh!

janschoenherr commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

janschoenherr commented Feb 24, 2025

Uh oh!

ghost commented Feb 26, 2025

Uh oh!

janschoenherr commented Feb 26, 2025

Uh oh!

ghost commented Feb 26, 2025 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unauthorised Links No

Unauthorised Links Yes

Uh oh!

Uh oh!

exlemor commented Mar 17, 2025

Uh oh!

ghost commented Mar 17, 2025

Uh oh!

joomdonation Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

janschoenherr Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

joomdonation Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

janschoenherr Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

exlemor commented Mar 17, 2025

Uh oh!

exlemor commented Mar 18, 2025

Uh oh!

janschoenherr commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

exlemor commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

janschoenherr commented Mar 18, 2025

Uh oh!

exlemor commented Mar 18, 2025

Uh oh!

exlemor commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

krishnaGandhi11 commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

janschoenherr commented Feb 21, 2025 •

edited

Loading

janschoenherr commented Feb 24, 2025 •

edited

Loading

ghost commented Feb 26, 2025 •

edited by ghost

Loading

Unauthorised Links `No`

Unauthorised Links `Yes`

janschoenherr commented Mar 18, 2025 •

edited

Loading

exlemor commented Mar 18, 2025 •

edited

Loading

exlemor commented Mar 18, 2025 •

edited

Loading

krishnaGandhi11 commented Mar 18, 2025 •

edited

Loading