[6.0] add router service provider / inject dispatcher in mvc factory and database driver #44371
+74
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and database driver
be9170e to
4bfbdee
Compare
heelc29
commented
Nov 12, 2024
|
Ready to review - check comment above |
laoneo
approved these changes
Jan 20, 2025
|
This pull request has been automatically rebased to 6.0-dev. |
heelc29
commented
Apr 22, 2025
laoneo
reviewed
Apr 22, 2025
Co-authored-by: Allon Moritz <[email protected]>
|
I have tested this item ✅ successfully on 5be6d9f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44371. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
test installation of joomla (with xdebug enabled)
Actual result BEFORE applying this Pull Request
If debug enabled:
UnexpectedValueException('Dispatcher not set in ...')KeyNotFoundException('Resource "InstallationRouter" has not been registered with the container.')Expected result AFTER applying this Pull Request
No debug message:
'Dispatcher not set in ...'orResource ... has not been registeredLink to documentations
Please select:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed