[6.0] Chunked download for the Joomla Update process

[MacJoom]

Please read the instructions carefully! Needs a new Joomla Installation and access to the joomla files (no Patch Tester)

Summary of Changes

• Introduce a new download process, first checks for the availability of the download source with a configurable timeout, gets filesize at the same time
• Does a chunked download (disabled by default, see options in update component)
• Fixes problem that only the first mirror was used - thanks to @Septdir
• Logs the download source, logs chunked download

Based on the #39280 from @nikosdion - thank you!

Testing Instructions

Cannot be tested using Patch Tester as there are NPM resources changed and need the joomla package to build (use prebuilt packages)
You need access to your joomla installation (e.g. FTP)

• Download the prebuild package under the checks below.
• Install Joomla
• Configure the options in the Update Component under Fine-tuning (Chunked downloads is disabled by default), the timeout in seconds for the first call to the downloadsite can be set there.
• Test with Chunked downloads disabled and enabled, try out different chunk sizes
• Manually modify libraries/src/Version.php: Set public const MINOR_VERSION = 1
  this way an update to 5.1.0 stable will be proposed since EXTRA_VERSION is on alpha1-dev (if not set it to alpha1-dev)
  you cannot update to 5.2.0 versions since there are no packages yet.

For experts only:
You can simulate an unavailable downloadserver with a setting in /etc/hosts of your server:
0.0.0.1 s3-us-west-2.amazonaws.com
and/or
0.0.0.1 objects.githubusercontent.com

REMEMBER: Your installation will be overwritten by the update! After the update your site will be on 5.1!

Actual result BEFORE applying this Pull Request

• Update sometimes fails because download may timeout
• Update sometimes fails because download fails on unavailable mirror

Expected result AFTER applying this Pull Request

• Update works as before
• Chunked download may fix problems with slow downloads

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[Septdir]

That restoring mirrors is not enough just removing unset.
If you want to restore their work, check out my PR.
There the very principle of working with mirrors was updated. And it’s not about timeout, of course, it’s needed to exclude non-working servers, but it doesn’t affect the very principle of receiving a link.

[MacJoom]

That restoring mirrors is not enough just removing unset. If you want to restore their work, check out my PR. There the very principle of working with mirrors was updated. And it’s not about timeout, of course, it’s needed to exclude non-working servers, but it doesn’t affect the very principle of receiving a link.

Ok thanks - i will look into it further. However in my tests i have all the expected download servers in the array.

[Septdir]

Another option is to completely abandon the iteration over all mirrors and give users the choice of which mirror to download from.

For example, I could choose Github on my end, while someone else might keep Amazon. Someone else might choose the third mirror.

Such an approach would eliminate the need to iterate through mirrors and give users the option.
"If the download fails, try switching the mirror in the settings."
A list of mirrors, just a select box with preset values.

This way, you can comfortably attempt to implement chunks while reducing the script execution time.

[HLeithner]

Suggested change

	* @since 2.5.4
	* @since __DEPLOY_VERSION__

[HLeithner]

Suggested change

	public function install(): void
	public function install()

b/c break

[wilsonge]

Component's not subject to b/c policy?

[HLeithner]

This pull request has been automatically rebased to 5.3-dev.

[HLeithner]

This pull request has been automatically rebased to 6.0-dev.