-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0] copy api language files #43152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.0-dev
Are you sure you want to change the base?
Conversation
Hi @heelc29, can you provide a test plugin/module/component that includes whatever you want us to test (I guess the language .ini file in place and code) so that we can test? (ready for testing so that we don't make mistakes in testing for you) It would make it a lot easier. Thanks. |
@MacJoom I wouldn't merge this in to 4.4, but your choice |
I have tested this item 🔴 unsuccessfully on 4474c5f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43152. |
@superd0ll how did you test this? |
This pull request has been automatically rebased to 5.3-dev. |
It was such a long time ago, I am sorry but I don't remember.. I need to check this out thoroughly. I will have time to do so after the 21st of November.. |
6b3c807
to
bb47c3f
Compare
This pull request has been automatically rebased to 6.0-dev. |
I have tested this item 🔴 unsuccessfully on 2cebb19 This is what I did: Warning An error has occurred. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43152. |
I have tested this item ✅ successfully on 0fb2a4a Also confirmed that with this PR the language file is removed from the api/languages folder This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43152. |
Pull Request for Issue #41944 .
Summary of Changes
Adds ability to place language files under
api/language
during installation of a componentUse example component:
com_mycomponent.zip
Testing Instructions
Add
languages
node under API in any component then test install/uninstallActual result BEFORE applying this Pull Request
language file
api\language\en-GB\com_mycomponent.ini
is not copiedExpected result AFTER applying this Pull Request
language file
api\language\en-GB\com_mycomponent.ini
is copied and deleted during uninstallLink to documentations
Please select:
Documentation link for docs.joomla.org: There is nothing special here https://docs.joomla.org/Manifest_files
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed