Skip to content

[6.0] Move 2 worflows input fields translations to global constants to separate from com_content #40694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: 6.0-dev
Choose a base branch
from

Conversation

artur-stepien
Copy link
Contributor

@artur-stepien artur-stepien commented May 31, 2023

Summary of Changes

This pull requests detaches workflow dropdown inputs from com_content component. It is required or other components using Workflows would require using COM_CONTENT translations or its translation prefix.

Testing Instructions

To test it fully you would require to build a custom component running workflows. Easiest is to check if Workflow input in Article Edit view and Articles list in administration still have the translation like previously:

  • Run Translation
  • Workflow Stage

Actual result BEFORE applying this Pull Request

obraz
obraz

Expected result AFTER applying this Pull Request

The inputs marked in screens above should have the same translation before and after patch.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Allow component based translation for transition-button layout
Use general translation constant to detach from COM_CONTENT
Add a more general translation constant to detach from COM_CONTENT
Add general translation constants for workflow dropdowns
@richard67 richard67 added the bug label Jun 1, 2023
@artur-stepien
Copy link
Contributor Author

@Quy @richard67 Willing to check this out? It was created over a month ago.

@obuisard obuisard changed the base branch from 4.3-dev to 4.4-dev August 14, 2023 00:13
@laoneo laoneo changed the base branch from 4.4-dev to 5.0-dev August 17, 2023 08:33
@laoneo
Copy link
Member

laoneo commented Aug 17, 2023

Thanks for the pr, I'v rebased it to 5.0 so it will get more attention for the pizza bugs and fun.

@Quy
Copy link
Contributor

Quy commented Sep 3, 2023

Should the Article Edit view use the new constant?

40694

@artur-stepien
Copy link
Contributor Author

Should the Article Edit view use the new constant?

Should, that's why there is a change in layouts/joomla/button/transition-button.php and libraries/src/MVC/Model/WorkflowBehaviorTrait.php and from what I saw it affected the com_content. I will test it again and let you know.

@ceford
Copy link
Contributor

ceford commented Sep 13, 2023

Tested but waiting for the outcome of previous comment.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40694.

@artur-stepien
Copy link
Contributor Author

artur-stepien commented Sep 13, 2023

Tested but waiting for the outcome of previous comment.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40694.

I will try to find the time for this tomorrow.

@HLeithner HLeithner added Feature Maintainers Checked Used if the PR is conceptional useful and removed bug labels Oct 5, 2023
@HLeithner HLeithner changed the title Move 2 worflows input fields translations to global constants to separate from com_content [5.1] Move 2 worflows input fields translations to global constants to separate from com_content Oct 5, 2023
@joomla-cms-bot joomla-cms-bot added Unit/System Tests and removed Language Change This is for Translators labels Jan 19, 2024
@Hackwar
Copy link
Member

Hackwar commented Feb 21, 2024

Can you make the requested change so that we can test it during PBF next saturday?

@Hackwar
Copy link
Member

Hackwar commented Feb 21, 2024

Actually, the PR seems to be broken right now, since it was rebased.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators and removed Unit/System Tests NPM Resource Changed This Pull Request can't be tested by Patchtester labels Feb 21, 2024
@bembelimen bembelimen removed the Feature label Mar 4, 2024
Copy link
Contributor Author

@artur-stepien artur-stepien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version update

@Quy Quy removed the PR-5.0-dev label Mar 23, 2024
@Quy
Copy link
Contributor

Quy commented Mar 25, 2024

Should, that's why there is a change in layouts/joomla/button/transition-button.php and libraries/src/MVC/Model/WorkflowBehaviorTrait.php and from what I saw it affected the com_content. I will test it again and let you know.

This still needs to be changed.

@HLeithner HLeithner changed the base branch from 5.1-dev to 5.2-dev April 24, 2024 09:08
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.2-dev.

@HLeithner HLeithner changed the title [5.1] Move 2 worflows input fields translations to global constants to separate from com_content [5.2] Move 2 worflows input fields translations to global constants to separate from com_content Apr 24, 2024
@HLeithner HLeithner changed the base branch from 5.2-dev to 5.3-dev September 2, 2024 08:52
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.3-dev.

@HLeithner HLeithner changed the title [5.2] Move 2 worflows input fields translations to global constants to separate from com_content [5.3] Move 2 worflows input fields translations to global constants to separate from com_content Sep 2, 2024
@Hackwar Hackwar removed the PR-5.2-dev label Sep 3, 2024
@HLeithner HLeithner changed the base branch from 5.3-dev to 6.0-dev March 4, 2025 17:22
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 6.0-dev.

@HLeithner HLeithner changed the title [5.3] Move 2 worflows input fields translations to global constants to separate from com_content [6.0] Move 2 worflows input fields translations to global constants to separate from com_content Mar 4, 2025
@rdeutz rdeutz removed the PR-5.3-dev label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Language Change This is for Translators Maintainers Checked Used if the PR is conceptional useful PR-6.0-dev Updates Requested Indicates that this pull request needs an update from the author and should not be tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.