-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0] Move 2 worflows input fields translations to global constants to separate from com_content #40694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.0-dev
Are you sure you want to change the base?
Conversation
Allow component based translation for transition-button layout
Use general translation constant to detach from COM_CONTENT
Add a more general translation constant to detach from COM_CONTENT
Add general translation constants for workflow dropdowns
Co-authored-by: Quy <[email protected]>
@Quy @richard67 Willing to check this out? It was created over a month ago. |
Thanks for the pr, I'v rebased it to 5.0 so it will get more attention for the pizza bugs and fun. |
Should, that's why there is a change in |
Tested but waiting for the outcome of previous comment. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40694. |
I will try to find the time for this tomorrow. |
Can you make the requested change so that we can test it during PBF next saturday? |
Actually, the PR seems to be broken right now, since it was rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version update
This still needs to be changed. |
This pull request has been automatically rebased to 5.2-dev. |
This pull request has been automatically rebased to 5.3-dev. |
This pull request has been automatically rebased to 6.0-dev. |
Summary of Changes
This pull requests detaches workflow dropdown inputs from com_content component. It is required or other components using Workflows would require using COM_CONTENT translations or its translation prefix.
Testing Instructions
To test it fully you would require to build a custom component running workflows. Easiest is to check if Workflow input in Article Edit view and Articles list in administration still have the translation like previously:
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
The inputs marked in screens above should have the same translation before and after patch.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed