[6.0] feat(task/checkfiles): Introduce image compression #40658

ditsuke · 2023-05-25T20:44:03Z

Summary of Changes

Introduces image compression to the image resizer plugin.

Why?

Resizing might result in a size increase, so we leave an option to compress.

Testing Instructions

Drop some images in a media folder (mix PNG, WEBP, JPG)
Configure a checkfiles task to resize/compress these images
Verify that the resized images are compressed with the right level.

Actual result BEFORE applying this Pull Request

No compression option. Image size may go up after the resize process.

Expected result AFTER applying this Pull Request

Compression option.

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed

plugins/task/checkfiles/src/Extension/Checkfiles.php

MrMusic · 2023-05-26T13:56:36Z

I suspect a mistake between compression <-> quality.
Usually, when processing jpeg images, the 'quality' is set in the range from 0 to 100, not the compression: Lower values are poor quality. Higher values are better quality.
To be consistent we should use 'quality'.

Co-authored-by: Brian Teeman <[email protected]>

plugins/task/checkfiles/forms/image_size.xml

Co-authored-by: Quy <[email protected]>

ditsuke · 2023-05-26T20:02:53Z

I suspect a mistake between compression <-> quality. Usually, when processing jpeg images, the 'quality' is set in the range from 0 to 100, not the compression: Lower values are poor quality. Higher values are better quality. To be consistent we should use 'quality'.

Honestly I'd prefer quality too, just that the initial discussion I had regarding this feature we talked about compression.

Co-authored-by: Brian Teeman <[email protected]>

ceford · 2023-09-13T14:23:46Z

I have tested this item 🔴 unsuccessfully on 38458ad

Several problems with the patch applied:
I see string keys rather than strings as the last Task Parameter
PLG_TASK_CHECK_FILES_LABEL_COMPRESSION *
PLG_TASK_CHECK_FILES_LABEL_COMPRESSION_DESC

I think the default value should be something reasonable, perhaps 75 rather than 0

The task does not actually run - Run Test just gives a Task: "Resize images" popup that never completes. If I close it I see a Running since ... Icon.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40658.}

HLeithner · 2023-09-30T22:50:01Z

This pull request has been automatically rebased to 5.1-dev.

HLeithner · 2024-04-24T09:08:33Z

This pull request has been automatically rebased to 5.2-dev.

ChrisHoefliger · 2024-07-15T17:20:02Z

I have tested this item ✅ successfully on 38458ad

I have tested this with an image of 5.3MB and 6000px width. Compressed to a width of 1200px and 80% quality it resulted in a file size of 669kB

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40658.}

ChrisHoefliger · 2024-07-15T17:20:04Z

I have tested this item ✅ successfully on 38458ad

I have tested this with an image of 5.3MB and 6000px width. Compressed to a width of 1200px and 80% quality it resulted in a file size of 669kB

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40658.}

dorisdreher · 2024-07-15T17:28:53Z

I have tested this item ✅ successfully on 38458ad

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40658.}

brianteeman · 2024-07-15T18:06:16Z

plugins/task/checkfiles/forms/image_size.xml

@@ -20,7 +20,7 @@
 				label="PLG_TASK_CHECK_FILES_LABEL_IMAGE_DIMENSION"
 				required="true"
 				default="width"
-				>
+			>


please revert this change

brianteeman · 2024-07-15T18:06:26Z

plugins/task/checkfiles/forms/image_size.xml

@@ -11,7 +11,7 @@
 				hide_none="true"
 				required="true"
 				validate="options"
-				>
+			>


please revert this change

brianteeman · 2024-07-15T18:21:03Z

I have no idea how you can say that you have tested this as at a minimum the new language strings are in the wrong file so it can only ever display the language keys as reported by @ceford earlier

brianteeman · 2024-07-15T18:21:43Z

administrator/language/en-GB/plg_task_checkfiles.sys.ini

+PLG_TASK_CHECK_FILES_LABEL_COMPRESSION="Compression"
+PLG_TASK_CHECK_FILES_LABEL_COMPRESSION_DESC="Choose the compression level to use when compressing files. 0 = no compression, 100 = maximum compression."


These strings should NOT be in the .sys.ini file They will do nothing here.

brianteeman · 2024-07-15T18:24:07Z

I have tested this item 🔴 unsuccessfully on 38458ad

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40658.}

brianteeman · 2024-07-15T18:31:38Z

Tried to do a test run

HLeithner · 2024-09-02T08:52:44Z

This pull request has been automatically rebased to 5.3-dev.

HLeithner · 2025-03-04T17:22:08Z

This pull request has been automatically rebased to 6.0-dev.

joomla-cms-bot added Language Change This is for Translators PR-4.3-dev labels May 25, 2023

ditsuke added 2 commits May 26, 2023 02:34

feat(task/checkfiles): Introduce image compression

d907224

chore: cleanup

6be9ed1

ditsuke force-pushed the feat/image-resizer-compression branch from 5fd8461 to 6be9ed1 Compare May 25, 2023 21:05

ditsuke requested review from laoneo, chmst, bembelimen, HLeithner, zero-24, rdeutz, Hackwar, fancyFranci and wilsonge as code owners May 25, 2023 21:05

joomla-cms-bot added Unit/System Tests and removed Language Change This is for Translators labels May 25, 2023

ditsuke changed the base branch from 4.3-dev to 5.0-dev May 25, 2023 21:24

brianteeman reviewed May 26, 2023

View reviewed changes

plugins/task/checkfiles/src/Extension/Checkfiles.php Outdated Show resolved Hide resolved

brianteeman reviewed May 26, 2023

View reviewed changes

plugins/task/checkfiles/src/Extension/Checkfiles.php Outdated Show resolved Hide resolved

alikon mentioned this pull request May 26, 2023

[4.4] Plugin: Allow Compression Option: Task/checkfiles/src/extension/checkfile.php [Feature Request] #40575

Closed

Kubik-Rubik reviewed May 26, 2023

View reviewed changes

plugins/task/checkfiles/src/Extension/Checkfiles.php Outdated Show resolved Hide resolved

Update plugins/task/checkfiles/src/Extension/Checkfiles.php

f229655

Co-authored-by: Brian Teeman <[email protected]>

joomla-cms-bot added Language Change This is for Translators PR-5.0-dev and removed Unit/System Tests labels May 26, 2023

Quy reviewed May 26, 2023

View reviewed changes

plugins/task/checkfiles/forms/image_size.xml Outdated Show resolved Hide resolved

chore: reorder form attrs

c80f8cd

Co-authored-by: Quy <[email protected]>

style: fix assignment alignment

84f35c0

Co-authored-by: Brian Teeman <[email protected]>

HLeithner added the Feature label Jun 3, 2023

HLeithner changed the base branch from 5.0-dev to 5.1-dev September 30, 2023 22:50

HLeithner changed the base branch from 5.1-dev to 5.2-dev April 24, 2024 09:08

HLeithner changed the title ~~feat(task/checkfiles): Introduce image compression~~ [5.2] feat(task/checkfiles): Introduce image compression Apr 24, 2024

joomla-cms-bot added the PR-5.2-dev label Apr 24, 2024

brianteeman reviewed Jul 15, 2024

View reviewed changes

Hackwar removed the PR-5.0-dev label Jul 21, 2024

HLeithner changed the base branch from 5.2-dev to 5.3-dev September 2, 2024 08:52

HLeithner changed the title ~~[5.2] feat(task/checkfiles): Introduce image compression~~ [5.3] feat(task/checkfiles): Introduce image compression Sep 2, 2024

joomla-cms-bot added the PR-5.3-dev label Sep 2, 2024

Hackwar removed the PR-5.2-dev label Sep 3, 2024

HLeithner changed the base branch from 5.3-dev to 6.0-dev March 4, 2025 17:22

HLeithner changed the title ~~[5.3] feat(task/checkfiles): Introduce image compression~~ [6.0] feat(task/checkfiles): Introduce image compression Mar 4, 2025

joomla-cms-bot added the PR-6.0-dev label Mar 4, 2025

rdeutz removed the PR-5.3-dev label Mar 5, 2025

exlemor added this to PR Cleanup May 10, 2025

exlemor moved this to Abandoned in PR Cleanup May 10, 2025

		PLG_TASK_CHECK_FILES_LABEL_COMPRESSION="Compression"
		PLG_TASK_CHECK_FILES_LABEL_COMPRESSION_DESC="Choose the compression level to use when compressing files. 0 = no compression, 100 = maximum compression."

Uh oh!

[6.0] feat(task/checkfiles): Introduce image compression #40658

Are you sure you want to change the base?

[6.0] feat(task/checkfiles): Introduce image compression #40658

Conversation

ditsuke commented May 25, 2023

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MrMusic commented May 26, 2023

Uh oh!

Uh oh!

ditsuke commented May 26, 2023

Uh oh!

ceford commented Sep 13, 2023

Uh oh!

HLeithner commented Sep 30, 2023

Uh oh!

HLeithner commented Apr 24, 2024

Uh oh!

ChrisHoefliger commented Jul 15, 2024

Uh oh!

ChrisHoefliger commented Jul 15, 2024

Uh oh!

dorisdreher commented Jul 15, 2024

Uh oh!

brianteeman Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

brianteeman Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

brianteeman commented Jul 15, 2024

Uh oh!

brianteeman Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

brianteeman commented Jul 15, 2024

Uh oh!

brianteeman commented Jul 15, 2024

Uh oh!

HLeithner commented Sep 2, 2024

Uh oh!

HLeithner commented Mar 4, 2025

Uh oh!

Uh oh!