Skip to content

[6.0] Filter articles in admin module mod_latest by workflow stage #37366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: 6.0-dev
Choose a base branch
from

Conversation

magnussinger
Copy link
Contributor

Pull Request for Issue #36802

Summary of Changes

In the backends latest articles module, one can now filter by active stages from the workflows of the respective articles

Testing Instructions

Create multiple articles with different stages of workflows, then edit the module to filter certain stages

Actual result BEFORE applying this Pull Request

You were not able to filter by stages

Expected result AFTER applying this Pull Request

You are now able to filter by workflow stage

Documentation Changes Required

None

@teekhandekar
Copy link

@magnussinger hey! here it says that this branch is out-of-date with the base branch
so is the issue still open and if yes can I work on this ?

@magnussinger
Copy link
Contributor Author

Hi @teekhandekar, you can always work on any issue if you want, and you don't need to ask for it. But in this case, I just had to merge the base branch into my branch, so it wasn't much to do.

@laoneo
Copy link
Member

laoneo commented Mar 28, 2022

@magnussinger can you rebase the pr to the 4.2-dev branch as it is a new feature?

@magnussinger
Copy link
Contributor Author

Sure

@magnussinger magnussinger changed the base branch from 4.1-dev to 4.2-dev March 28, 2022 13:49
@richard67 richard67 added the PBF Pizza, Bugs and Fun label Apr 22, 2022
@brianteeman
Copy link
Contributor

Sorry but this is not correct.

  1. Instead of the sql field why not use the existing workflowstage field type. This has numerous advantages especially when there is more that one workflow on the site
  2. You are not checking to see if the site is using workflows before display the stage field

@Quy Quy added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Jun 6, 2022
@joomla-bot
Copy link
Contributor

This pull requests has been automatically converted to the PSR-12 coding standard.

@HLeithner HLeithner changed the title [5.2] Filter articles in admin module mod_latest by workflow stage [5.3] Filter articles in admin module mod_latest by workflow stage Sep 2, 2024
@Hackwar Hackwar removed the PR-5.2-dev label Sep 3, 2024
@Pritams43
Copy link

I have tested this item ✅ successfully on b260e85

I have Tested this item


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.

@Pritams43
Copy link

I have Tested this item successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.

@crommie
Copy link

crommie commented Feb 22, 2025

I have tested this item ✅ successfully on b260e85

Tested succesfully, works as described


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.

@webfeuerflo
Copy link

Could not see any change in the Latest Article Module on ‎5.3.0-beta1 with the patch applied

@webfeuerflo
Copy link

Sorry, was not testing with the admin module. Now tested successfully!

@softforge
Copy link
Contributor

I have tested this item ✅ successfully on b260e85


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.

@joomla-cms-bot joomla-cms-bot removed Feature Updates Requested Indicates that this pull request needs an update from the author and should not be tested. PBF Pizza, Bugs and Fun Small A PR which only has a small change PR-5.3-dev labels Feb 22, 2025
@alikon
Copy link
Contributor

alikon commented Feb 22, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 22, 2025
@alikon alikon added PBF Pizza, Bugs and Fun PR-5.3-dev Feature labels Feb 22, 2025
@rdeutz rdeutz changed the base branch from 5.3-dev to 6.0-dev February 28, 2025 12:23
@rdeutz rdeutz changed the title [5.3] Filter articles in admin module mod_latest by workflow stage [6.0] Filter articles in admin module mod_latest by workflow stage Feb 28, 2025
@rdeutz rdeutz removed the PR-5.3-dev label Feb 28, 2025
@brianteeman
Copy link
Contributor

Not sure how anyone was able to test this successfully. There are several problems that I see when testing it

  1. The filter for workflow stage is displayed even when workflows is not enabled
  2. If you have multiple workflows then the selection list does not differentiate them
  3. The default Basic Workflow has only one stage but it is displayed as a language constant not a language value

image

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on e2bdaf3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.

@brianteeman
Copy link
Contributor

Looking back at all the previous comments I see that I am not the first to report the problems with this PR. It should never have been marked as RTC

@QuyTon QuyTon added Updates Requested Indicates that this pull request needs an update from the author and should not be tested. and removed RTC This Pull Request is Ready To Commit labels Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature PBF Pizza, Bugs and Fun PR-6.0-dev Updates Requested Indicates that this pull request needs an update from the author and should not be tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.