-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0] Filter articles in admin module mod_latest by workflow stage #37366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.0-dev
Are you sure you want to change the base?
Conversation
@magnussinger hey! here it says that this branch is out-of-date with the base branch |
Hi @teekhandekar, you can always work on any issue if you want, and you don't need to ask for it. But in this case, I just had to merge the base branch into my branch, so it wasn't much to do. |
@magnussinger can you rebase the pr to the 4.2-dev branch as it is a new feature? |
Sure |
Sorry but this is not correct.
|
This pull requests has been automatically converted to the PSR-12 coding standard. |
I have tested this item ✅ successfully on b260e85 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366. |
I have Tested this item successfully This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366. |
I have tested this item ✅ successfully on b260e85 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366. |
Could not see any change in the Latest Article Module on 5.3.0-beta1 with the patch applied |
Sorry, was not testing with the admin module. Now tested successfully! |
I have tested this item ✅ successfully on b260e85 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366. |
Not sure how anyone was able to test this successfully. There are several problems that I see when testing it
|
I have tested this item 🔴 unsuccessfully on e2bdaf3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366. |
Looking back at all the previous comments I see that I am not the first to report the problems with this PR. It should never have been marked as RTC |
Pull Request for Issue #36802
Summary of Changes
In the backends latest articles module, one can now filter by active stages from the workflows of the respective articles
Testing Instructions
Create multiple articles with different stages of workflows, then edit the module to filter certain stages
Actual result BEFORE applying this Pull Request
You were not able to filter by stages
Expected result AFTER applying this Pull Request
You are now able to filter by workflow stage
Documentation Changes Required
None