Wrong autoload fields path for redefined administrator folder

[pinta83]

Steps to reproduce the issue

Change "administrator" folder in "/includes/defines.php" and "/administrator/includes/defines.php" to "admin"
rename "administrator" folder to "admin"

Expected result

Everything working

Actual result

Fields not getting loaded due to wrong path

System information (as much as possible)

Joomla 5.x

Additional comments

Fix paths in the "prepareForm" function in administrator/components/com_fields/src/Helper/FieldsHelper.php lines 430 and 431.

CURRENT CODE

$fieldset->setAttribute('addfieldpath', '/administrator/components/' . $component . '/models/fields');
$fieldset->setAttribute('addrulepath', '/administrator/components/' . $component . '/models/rules');

PROPOSED FIX

$fieldset->setAttribute('addfieldpath', str_replace(JPATH_ROOT, '', JPATH_ADMINISTRATOR) . '/components/' . $component . '/models/fields');
$fieldset->setAttribute('addrulepath', str_replace(JPATH_ROOT, '', JPATH_ADMINISTRATOR) . '/components/' . $component . '/models/rules');

Related

Related to issue #44980

[brianteeman]

there are lots of places where the code will be broken by changing the name of the admin folder. to the best of my knowledge it has never been supported for the administrator folder to be renamed

[pinta83]

As for the Joomle core, this should be it. I'm using it with changed administrator folder - and this is 2 out 2 that is making problems. The other bug i reported is fixed.

The folder is in defines.php as are all other path constants - so I wouldn't agree that it has never been supported.
Joomla 3 did a good job with no problem, this bugs were introduced with J4.

[brianteeman]

As for the Joomle core, this should be it. I'm using it with changed administrator folder - and this is 2 out 2 that is making problems. The other bug i reported is fixed.

check the code - i can assure you that there are many other areas

[joomdonation]

@pinta83 Since you have solution, could you please make a PR with the proposed changes ?

[chmst]

@pinta83 Thank you for working on that. Could you please make your PR as a PR on Joomla, the branch 5.3-dev?