Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing CSS helpers in No Dark Mode version #3736

Closed
idybil opened this issue Mar 22, 2024 · 5 comments
Closed

Missing CSS helpers in No Dark Mode version #3736

idybil opened this issue Mar 22, 2024 · 5 comments

Comments

@idybil
Copy link

idybil commented Mar 22, 2024

First of all, a big thank you for your great work! I've done tons of projects with the 0.9.4 version and your version 1.0.0 seems great. I especially appreciate the CSS variables.

Overview of the problem

This is about the Bulma CSS framework
I'm using Bulma --> 1.0.0
My browser is: any

Description

It seems that the "bulma-no-dark-mode.min.css" version does not contains the CSS helpers.

Steps to Reproduce

  1. Use the "bulma-no-dark-mode.min.css" in your html <head>.
  2. Put any html element with a CSS help class, example <h1 class="has-text-link mb-5">Hi!</h1>

Expected behavior

The <h1> tag from the example above should have the text-link color and have a margin-bottom.

Actual behavior

The <h1> tag from the example above does not have the text-link color and have a margin-bottom.

Question

Is it possible to include the CSS helper in the "bulma-no-dark-mode.min.css" version or have a new version having the helpers ?

Thanks
@onli
Copy link

onli commented Mar 22, 2024

I also see no effect from has-background-light in the no dark mode version. Is that related, and maybe also unintended?

@dbrgn
Copy link
Contributor

dbrgn commented Mar 23, 2024

Same here: has-text-danger seems to work in the regular version, but not in no-dark-mode.

A fixed no-dark-mode version would be very much appreciated, since it allows upgrade to 1.0 for sites that don't yet work properly with dark mode (or where a dark mode is simply undesired).

@dbrgn dbrgn mentioned this issue Mar 23, 2024
Merged
@wlh320
Copy link

wlh320 commented Mar 25, 2024

I guess it is because a missing @forward "helpers"; in versions/bulma-no-dark-mode.scss.
I use npm to install bulma, add this line referring to sass/_index.scss, and manually compile it using npm run build-all as a temporary solution.

@max-arnold
Copy link

+1

Minified CSS size went from 207kb for 0.9.4 to 647kb for 1.0.0 (more than tripled!). How to get the same functionality with a similar CSS bundle size?

dbrgn added a commit to dbrgn/flugbuech that referenced this issue Mar 31, 2024
@dbrgn
Patch bulma to include helpers
2438951 
See jgthms/bulma#3736 (comment)
dbrgn added a commit to dbrgn/flugbuech that referenced this issue Mar 31, 2024
@dbrgn
Use no-dark-mode version of BulmaCSS
fa3d4f3 
While the dark mode works generally, there are various issues with it,
and I don't currently want to spend my time fine-tuning the dark mode.

Note: The bundle is patched to include helpers,
see jgthms/bulma#3736 (comment)
dbrgn added a commit to dbrgn/flugbuech that referenced this issue Mar 31, 2024
@dbrgn
Use no-dark-mode version of BulmaCSS
f6ee928 
While the dark mode works generally, there are various issues with it,
and I don't currently want to spend my time fine-tuning the dark mode.

Note: The bundle is patched to include helpers,
see jgthms/bulma#3736 (comment)
@jgthms jgthms closed this as completed in e9a4aac Apr 29, 2024
@idybil
Copy link
Author

idybil commented Apr 29, 2024

Thanks @jgthms

@falgon falgon mentioned this issue May 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dbrgn @max-arnold @onli @idybil @wlh320