Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #39 #42

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Fix #39 #42

merged 3 commits into from
Nov 17, 2020

Conversation

theidexisted
Copy link
Contributor

@theidexisted theidexisted commented Nov 17, 2020

Cpprefenre have changed their wiki to add template in header part:
Previous format:

std::basic_string::find

Current format:

std::basic_string<CharT,Traits,Allocator>::find

To remove the template with regex will fix the current break

Cpprefenre have changed their wiki to add tempalte in header part:
Previous format:
std::basic_string::find

Current format:
std::basic_string<CharT,Traits,Allocator>::find

So remove the template with regex will fix current break
@jeaye
Copy link
Owner

jeaye commented Nov 17, 2020

Thanks for the change! Would you mind doing one more generation, after adding Categories, Hidden category, and Hidden categories to the section list, similar to this manual addition? https://github.com/jeaye/stdman/blob/master/src/groff_section.hpp#L129

I see them showing up in the diff here, so they must be new:

If you're not up for it, I can merge this, add the new sections, and then do another generation myself some time this week.

@theidexisted
Copy link
Contributor Author

Thanks, I will follow up on your guides and commit the change latter.

I also suggest now we change the c++ version to c++17 since it's widely used today, what's your opinion?

@theidexisted
Copy link
Contributor Author

I have added these new sections, could you please review it again.

@jeaye
Copy link
Owner

jeaye commented Nov 17, 2020

Thanks for the additional changes! Changing to C++17 is no problem, but we can do that in another PR.

@jeaye jeaye merged commit 478d353 into jeaye:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants