Pass http proxy as env to command (fix #136, #117) #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @edvardchen for contribution. |
…ode-OpenSource#117) We use leetcode-cli and leetcode-cli uses request to call LeetCode web API. It's lucky that request respects the http proxy env variables(http_proxy, https_proxy), so all we need to do is passing proxy as env variable http_proxy to every command. TODO: do we need to set https_proxy for https request?
aeb2a04 to
e4cb64c
Compare
|
Yes. |
|
@edvardchen Awesome, I'll take a look later, thanks! |
|
Hi @edvardchen What will happen if we don't set https_proxy for https request |
|
request will use http_proxy as fallback |
|
Because vscode user setting doesn't have a https.proxy option, so we should not worry about it. |
jdneo
reviewed
Feb 23, 2019
src/utils/workspaceUtils.ts
Outdated
| } | ||
|
|
||
| // clone process.env and add http proxy | ||
| export function createEnvOption(): {} { |
There was a problem hiding this comment.
Looks like cpUtils.ts is a better place to put this method?
There was a problem hiding this comment.
Sure. I'll move it there.
|
@edvardchen Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use leetcode-cli and leetcode-cli uses request to call LeetCode web API.
It's lucky that request respects the http proxy env variables(http_proxy, https_proxy),
so all we need to do is passing proxy as env variable http_proxy to every command.
TODO: do we need to set https_proxy for https request?