Skip to content

Remove BigInt IE incompatibility part #3709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

FloffyGarlic
Copy link
Contributor

As Internet Explorer was retired years ago, this paragraph is not needed anymore, so I deleted that line.

As Internet Explorer was retired years ago, this paragraph is not needed anymore, so I deleted that line.
@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Jul 3, 2024
@javascript-translate-bot javascript-translate-bot requested a review from a team July 3, 2024 06:51
@CLAassistant
Copy link

CLAassistant commented Jul 3, 2024

CLA assistant check
All committers have signed the CLA.

Unimportant link: almost total compatibility since the appearance of zhe `BigInt` type.
Copy link

@mohitgedar mohitgedar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today BigInt is supported by edge , the new IE , but I thing the link to MDN will be useful in the content . I think deleting the whole part is not required , just modify it to give a reference to MDN to check compatibilites . and also remove that BigInt is not supported in edge , you understand what I am trying to say ?

@joaquinelio
Copy link
Member

The link, in this context (" You can check..."), is useless, it's all checked and IE is missing.
I would Remove it..

Should the ref to IE be removed?

Many references to IE compatibility exist in the tutorial. I once submitted a PR removing all of them, but I was told that IE is still used in corporate environments that have not yet migrated.
Maybe is time, I don't know.

Also
the tutorial includes explanations for old and no longer recommended functions and practices because students may encounter old code using them
so maybe ie refs can stay.
Nah, in this particular case I would remove it too.

@FloffyGarlic
Copy link
Contributor Author

We could mention something along the lines of "Although virtually all browsers support BigInts today, they still count as a relatively new feature. You can check [insert MDN compatibility table] to check which version of each browser is compatible with BigInt". However, I still think it's redundant. Sure, knowing about the MDN reference is important, but since the type is compatible with virtually every browser, the MDN compatibility reference is not necessary anymore when it comes to BigInts themselves. Thus, it probably doesn't deserve a place in the BigInts paragraph. It's good to be concise.

@FloffyGarlic
Copy link
Contributor Author

FloffyGarlic commented Jul 5, 2024

The link, in this context (" You can check..."), is useless, it's all checked and IE is missing. I would Remove it..

Should the ref to IE be removed?

Many references to IE compatibility exist in the tutorial. I once submitted a PR removing all of them, but I was told that IE is still used in corporate environments that have not yet migrated. Maybe is time, I don't know.

Also the tutorial includes explanations for old and no longer recommended functions and practices because students may encounter old code using them so maybe ie refs can stay. Nah, in this particular case I would remove it too.

@joaquinelio May I ask for a review if you approve of this change?

Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

The link is waste of time, it shows all checked today

The IE incompatibility ref doesn't add anything.

@javascript-translate-bot javascript-translate-bot added needs +1 One more review needed and removed review needed Review needed, please approve or request changes labels Jul 9, 2024
@joaquinelio
Copy link
Member

@joaquinelio May I ask for a review if you approve of this change?

@FloffyGarlic
It's not matter of approval, the eepo is having little activity

About IE, even retired, the tutorial still shows it because of the old code (corporate code in this case) you may still encounter. Here I just dont think it is useful

@smith558 smith558 self-assigned this Jul 9, 2024
@smith558 smith558 removed the needs +1 One more review needed label Jul 9, 2024
@smith558 smith558 merged commit d6e0376 into javascript-tutorial:master Jul 9, 2024
1 check passed
@smith558
Copy link
Member

smith558 commented Jul 9, 2024

Thank you for your contribution! 🙂 @FloffyGarlic And the review! @joaquinelio @mohitgedar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants