-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Remove BigInt IE incompatibility part #3709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As Internet Explorer was retired years ago, this paragraph is not needed anymore, so I deleted that line.
Unimportant link: almost total compatibility since the appearance of zhe `BigInt` type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today BigInt is supported by edge , the new IE , but I thing the link to MDN will be useful in the content . I think deleting the whole part is not required , just modify it to give a reference to MDN to check compatibilites . and also remove that BigInt is not supported in edge , you understand what I am trying to say ?
The link, in this context (" You can check..."), is useless, it's all checked and IE is missing. Should the ref to IE be removed? Many references to IE compatibility exist in the tutorial. I once submitted a PR removing all of them, but I was told that IE is still used in corporate environments that have not yet migrated. Also |
We could mention something along the lines of "Although virtually all browsers support BigInts today, they still count as a relatively new feature. You can check [insert MDN compatibility table] to check which version of each browser is compatible with BigInt". However, I still think it's redundant. Sure, knowing about the MDN reference is important, but since the type is compatible with virtually every browser, the MDN compatibility reference is not necessary anymore when it comes to BigInts themselves. Thus, it probably doesn't deserve a place in the BigInts paragraph. It's good to be concise. |
@joaquinelio May I ask for a review if you approve of this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
The link is waste of time, it shows all checked today
The IE incompatibility ref doesn't add anything.
@FloffyGarlic About IE, even retired, the tutorial still shows it because of the old code (corporate code in this case) you may still encounter. Here I just dont think it is useful |
Thank you for your contribution! 🙂 @FloffyGarlic And the review! @joaquinelio @mohitgedar |
As Internet Explorer was retired years ago, this paragraph is not needed anymore, so I deleted that line.