Skip to content

Fix grammar and typos #3628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

nakhodkin
Copy link
Contributor

No description provided.

@smith558 smith558 self-assigned this Feb 14, 2024
@javascript-translate-bot javascript-translate-bot added the needs +1 One more review needed label Feb 14, 2024
@smith558 smith558 merged commit ab1db04 into javascript-tutorial:master Feb 14, 2024
@smith558 smith558 removed the needs +1 One more review needed label Feb 14, 2024
@smith558
Copy link
Member

Thank you for your contribution! 🙂

@joaquinelio
Copy link
Member

joaquinelio commented Feb 14, 2024

(Warning I'm not English native speaker)

PLEASE @iliakan
@smith558

I agree with most fixes but I think
"A quick glance"
"You really know"
"Clearly communicate"
"Your own mind"
Really emphasizes ideas, if you take those "superfluous" words off they sound more silly and forgettable,
next fix would be to take off the entire sentence and transform the tutorial in just a structured reference.

@joaquinelio
Copy link
Member

about
"Agree on terms within your team and in your own mind."
It's subtle.
If you erase "own", the implicit warning is no more.
The warning, people working alone tend to relax rules.
It is evident when reading the aricle,
not so when correcting out of context sentences.

@smith558
Copy link
Member

smith558 commented Feb 14, 2024

your own

"your team" implies, in fact, semantically requires that the team is his/her own. Therefore "your own" should not be necessary. (source) It is in most cases used purely for emphasis. Do you feel it's necessary here?

In the case of "quick glance", "really know", "clearly communicate" and likewise. I would say in this article the modifiers in these phrases do not serve a clear purpose and mostly clutter the sentences. Let me know what you think! 🙂

These are definitely good points.

@joaquinelio
Copy link
Member

It's ok the lint command,
but our languages don't require minifiers 😄

I liked
"Buy your food"
"Buy your own food"
the last implies some reproval.
You could avoid "own", but if you say it aloud, you would say
"Buy YOUR food" with maybe an accusatory finger.
Expressiveness is the key.

I don't thing they clutter sentences.
Wrong grammar does.

@joaquinelio
Copy link
Member

Sorry
Too much debate for a style topic

I would say
focus on real grammar issues, there are many of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants