remove base_kernel_url

[minrk]

While we are simplifying base_project_url to base_url, base_kernel_url has never been documented, and has only ever been confusing. In every case I have seen, base_kernel_url should be identical to base_url, so this just removes the separate configuration value.

I would also like to consider getting rid of ws_url, unless someone can make a case for why it should be kept.

closes #5099

[takluyver]

The term 'kernel server' in a docstring suggests that at one point we were considering that kernels could be handled by a different webserver from the notebooks. Was that ever the case? I don't remember hearing any discussion of it.

[ellisonbg]

I think it probably was to handle the case of kernels running on a
different server. But I don't think we need that anymore (never did).

On Wed, Feb 12, 2014 at 4:15 PM, Thomas Kluyver [email protected]:

The term 'kernel server' in a docstring suggests that at one point we were
considering that kernels could be handled by a different webserver from the
notebooks. Was that ever the case? I don't remember hearing any discussion
of it.

Reply to this email directly or view it on GitHubhttps://github.com//pull/5100#issuecomment-34934786
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
[email protected] and [email protected]

[minrk]

And because of the new URL scheme, a proxy can send /api/kernels to a different server anyway, so I don't think the separate configurable solves a problem. Related: Can we also get rid of ws_url, or no?

[ellisonbg]

Hmm, I don't actually remember the details is ws_url - will have to look

Sent from my iPhone

On Feb 12, 2014, at 6:14 PM, Min RK [email protected] wrote:

And because of the new URL scheme, a proxy can send /api/kernels to a different server anyway, so I don't think the separate configurable solves a problem. Related: Can we also get rid of ws_url, or no?

—
Reply to this email directly or view it on GitHub.

[minrk]

Hmm, I don't actually remember the details is ws_url - will have to look

It's the same as base_kernel_url - a separate URL, so that the websockets can be on another host. Never used, and can also be handled in the server via a proxy.

[takluyver]

I don't see any problem with getting rid of ws_url.

[ellisonbg]

The removal of base_kernel_url looks fine. Looking at the ws_url stuff now.

[ellisonbg]

@minrk will remove ws_url in a later PR.