Skip to content

sphinx and PDF tweaks #3948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2013
Merged

sphinx and PDF tweaks #3948

merged 2 commits into from
Aug 8, 2013

Conversation

minrk
Copy link
Member

@minrk minrk commented Aug 8, 2013

  • add --interaction=batchmode to pdflatex call

avoids waiting for input

  • use sphinx.package_dir to find texinputs

this can vary, e.g. for debian installs it is /usr/share/sphinx

closes #3894

minrk added 2 commits August 7, 2013 17:25
this can be different for debian installs, etc.
@minrk minrk mentioned this pull request Aug 8, 2013
@jdfreder
Copy link
Contributor

jdfreder commented Aug 8, 2013

If pdflatex fails or requests input, does this just fail silently?

@fperez
Copy link
Member

fperez commented Aug 8, 2013

Test suite passes here, thanks so much! Merging now...

@fperez
Copy link
Member

fperez commented Aug 8, 2013

@jdfreder, I think pdflatex will set the status code correctly in this case, but I haven't checked yet...

fperez added a commit that referenced this pull request Aug 8, 2013
Sphinx and PDF tweaks for nbconvert:

- add `--interaction=batchmode` to pdflatex call to avoid waiting for interactive input.

- use sphinx.package_dir to find texinputs directory regardless of on-disk location.

Closes #3894.
@fperez fperez merged commit c293fc5 into ipython:master Aug 8, 2013
@minrk minrk deleted the sphinx-dir branch August 8, 2013 00:51
@minrk
Copy link
Member Author

minrk commented Aug 8, 2013

I think --interaction=batchmode is actually the wrong thing to do here. Will make another PR that does it better.

@fperez
Copy link
Member

fperez commented Aug 8, 2013

OK. At least this fixes the open bug ;)

@minrk
Copy link
Member Author

minrk commented Aug 8, 2013

PR #3949 should give better information

@fperez
Copy link
Member

fperez commented Aug 8, 2013

You mean #3949...

@minrk
Copy link
Member Author

minrk commented Aug 8, 2013

I do indeed.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sphinx and PDF tweaks for nbconvert:

- add `--interaction=batchmode` to pdflatex call to avoid waiting for interactive input.

- use sphinx.package_dir to find texinputs directory regardless of on-disk location.

Closes ipython#3894.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nbconvert test failure
3 participants