nbconvert: Add cwd to sys.path #3752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes transformers and filters in the cwd load from dotted object names.
|
are there any relative imports in nbconvert code path that might be affected by this? |
| """ | ||
| Add the cwd to the sys.path ($PYTHONPATH) | ||
| """ | ||
| sys.path.append(os.getcwd()) |
There was a problem hiding this comment.
typically you put this at the front (path.insert(0, '.')), so it's highest priority.
|
done |
|
bump |
Carreau
added a commit
that referenced
this pull request
Jul 26, 2013
nbconvert: Add cwd to sys.path This makes transformers and filters in the cwd load from dotted object names.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
nbconvert: Add cwd to sys.path This makes transformers and filters in the cwd load from dotted object names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes transformers and filters in the cwd load
from dotted object names.
Disclaimer: The new init def is not required, I thought it looked better (so the initialize def only contains init... functions). If we remove it the changes are one line_