Pass host environment on to kernel #2878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why copy? |
|
No need here actually. I tend to copy so that changes aren't reflected in the host but obviously, there are no changes here. I can remove and resubmit? |
|
You can either add a commit that remove the copy and push, or amend/rebase the commit and force push. |
The main motivation for this was to make PYTHONPATH settings apply to the kernels.
|
looks good, thanks! |
minrk
added a commit
that referenced
this pull request
Feb 4, 2013
Pass host environment on to kernel
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Pass host environment on to kernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation for this was to make PYTHONPATH settings
apply to the kernels.