Fix pretty print of types when __module__ is not available.
#2685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3, heap allocated types -- for example those created using PyType_FromSpec -- lack the `__module__` attribute. Closes ipython#2684
| mod = obj.__module__ | ||
| except AttributeError: | ||
| # Heap allocated types might not have the module attribute. | ||
| return p.text(obj.__name__) |
There was a problem hiding this comment.
There's no way __name__ could be missing too, I hope?
There was a problem hiding this comment.
No, I went and read the C source -- name will always be defined.
|
Great, looks good to me, then. Could we also add a simple tests? It can be conditional on |
|
Okay, added a test. I think it was skipped on Travis py32 test, but it runs for me locally. |
|
Great, thanks. I'll land this, then. |
takluyver
added a commit
that referenced
this pull request
Dec 16, 2012
Fix pretty print of types when `__module__` is not available.
minrk
added a commit
that referenced
this pull request
Mar 5, 2013
… available. In Python 3, heap allocated types -- for example those created using PyType_FromSpec -- lack the `__module__` attribute. Closes #2684
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Fix pretty print of types when `__module__` is not available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3, heap allocated types -- for example those created using
PyType_FromSpec -- lack the
__module__attribute.Closes #2684