Skip to content

Fix: longest_substr([]) -> '' #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2012
Merged

Conversation

bfroehle
Copy link
Contributor

@bfroehle bfroehle commented Aug 5, 2012

Previously the algorithm used to find the longest common starting substring
unintentionally raised an error when it was called on an empty list.

This should fix the issue of an error being raised when running %paste
on an empty clipboard (#2252).

Previously the algorithm used to find the longest common starting substring
unintentionally raised an error when it was called on an empty list.
@takluyver
Copy link
Member

Test results for commit da6e82b merged into master
Platform: linux2

  • python2.7: OK (libraries not available: oct2py rpy2)
  • python3.2: OK (libraries not available: cython oct2py pymongo rpy2 wx wx.aui)

Not available for testing: python2.6

@takluyver
Copy link
Member

Looks OK. Merging now, thanks.

takluyver added a commit that referenced this pull request Aug 6, 2012
@takluyver takluyver merged commit e431d6b into ipython:master Aug 6, 2012
@minrk
Copy link
Member

minrk commented Aug 6, 2012

Test results for commit da6e82b merged into master (123c4d6)
Platform: darwin

  • python2.6: OK (libraries not available: cython matplotlib oct2py pygments pymongo qt rpy2 tornado wx wx.aui)
  • python2.7: OK (libraries not available: oct2py rpy2 wx wx.aui)
  • python3.2: OK (libraries not available: cython matplotlib oct2py pygments pymongo qt rpy2 wx wx.aui)

Not available for testing:

minrk added a commit that referenced this pull request Aug 9, 2012
Previously the algorithm used to find the longest common starting substring
unintentionally raised an error when it was called on an empty list.

This should fix the issue of an error being raised when running %paste
on an empty clipboard (#2252).
minrk added a commit that referenced this pull request Sep 1, 2012
Previously the algorithm used to find the longest common starting substring
unintentionally raised an error when it was called on an empty list.

This should fix the issue of an error being raised when running %paste
on an empty clipboard (#2252).
yarikoptic added a commit to yarikoptic/ipython that referenced this pull request May 2, 2014
* commit 'rel-0.13-33-gcfc5692': (33 commits)
  Backport PR ipython#2347: adjust division error message checking to account for Python 3
  Backport PR ipython#2305: RemoteError._render_traceback_ calls self.render_traceback
  Backport PR ipython#2280: fix SSH passwordless check for OpenSSH
  Backport PR ipython#2270: SSHLauncher tweaks
  Backport PR ipython#2261: Fix: longest_substr([]) -> ''
  Backport PR ipython#2250: fix html in notebook example
  Backport PR ipython#2235: remove spurious print statement from setupbase.py
  fixup
  Backport PR ipython#2223: Custom tracebacks
  Backport PR ipython#2214: use KernelApp.exec_lines/files in IPEngineApp
  Backport PR ipython#2212: catch errors in markdown javascript
  Backport PR ipython#2194: clean nan/inf in json_clean
  Backport PR ipython#2177: remove numpy install from travis/tox scripts
  Backport PR ipython#2169: ipdb: pdef, pdoc, pinfo magics all broken
  Backport PR ipython#2186: removed references to h5py dependence in octave magic documentation
  Backport PR ipython#2185: added test for %store, fixed storemagic
  Backport PR ipython#2170: Fix tab completion with IPython.embed_kernel().
  Backport PR ipython#2163: fix 'remote_profie_dir' typo in SSH launchers
  Backport PR ipython#2117: use explicit url in notebook example
  Backport PR ipython#2126: ipcluster broken with any batch (PBS/LSF/SGE)
  ...
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants