py3compat fixes for %%script and tests #1907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
running test_pr on this one now... |
|
Same here :) |
|
hm, appears to be hanging somewhere else now. |
|
oh, right - now I remember one of the reasons I haven't been running test_pr: I get a bunch of: errors for every cython test, due to the reload tests having altered distutils. |
|
Test results for commit 60a14b4 merged into master
Not available for testing: |
|
Ah, since I don't have cython on py3, I don't get those. Let's merge this now as-is, we can try to work out the cython stuff elsewhere. Great job, thanks!! |
fperez
added a commit
that referenced
this pull request
Jun 11, 2012
py3compat fixes for %%script and tests. fixes hang in test_pr, caused by error raised in background thread (%%script --bg), and main thread waiting on the close of an FD that would never close due to the error.
|
I actually get the Cython failures on Python 2.7. I think we should probably disable all reload tests until we can figure out how to give them their own special test group. |
|
Sounds good, I have no problem with that. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
py3compat fixes for %%script and tests. fixes hang in test_pr, caused by error raised in background thread (%%script --bg), and main thread waiting on the close of an FD that would never close due to the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes hang in test_pr, caused by error raised in background thread (%%script --bg), and main thread waiting on the close of an FD that would never close due to the error.