import_item fails when one tries to use DottedObjectName instead of a string

[jdfreder]

import_item fails when one tries to use DottedObjectName instead of a string

out:

File "/home/jonathan/ipython/IPython/utils/importstring.py", line 38, in import_item
parts = name.rsplit('.', 1)
AttributeError: 'DottedObjectName' object has no attribute 'rsplit'

[minrk]

Then there's something wrong in your traits code.a DottedObjectName trait is always a string. Can you point out where you are trying to do this?

[jdfreder]

Declaration

writer_class = DottedObjectName('FilesWriter', config=True,
help="""Writer class used to write the
results of the conversion""")
writer_aliases = {'FilesWriter': DottedObjectName('IPython.nbconvert.writers.files.FilesWriter'),
'DebugWriter': DottedObjectName('IPython.nbconvert.writers.debug.DebugWriter'),
'StdoutWriter': DottedObjectName('IPython.nbconvert.writers.stdout.StdoutWriter')}

Usage

def _writer_class_changed(self, name, old, new):
if new in NbConvertApp.writer_aliases:
self.writer_factory = import_item(NbConvertApp.writer_aliases[new])
else:
self.writer_factory = import_item(new)

[minrk]

Gotcha - you should be passing the app instance, not the App class.

[minrk]

is writer_class a trait on the App? If so, just use self.

[jdfreder]

Ahhh!!!!!