Fix string input2 #265
Merged
Fix string input2 #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In doctests, _ *must* be special-cased and removed from the user's namespace because otherwise Python won't set it. But we were doing this special-casing unconditionally, making it impossible to write unittests that checked the _ variable after cell execution. This commit makes the special-casing of _ apply only in the doctest execution (where it's needed) and leaves normal unittests alone.
The actual bug fix was a trivial one-line change, made here. The rest of the commits in this series improve our testing machinery and clean up related code. The actual fix was just calling the run_source instead of the run_code method, which should only be called with compiled code objects.
|
+1 |
|
Looks good to me. |
|
Thanks a lot for the reviews! Pushed and closed. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the fix started by Robert Kern for the execution of naked strings. This fixes the case where the input is a multiline string.
The actual fix was a trivial one-liner, but I took the opportunity to clean up some aspects of our test system to simplify them and remove some odd special casing that made testing harder. This let me add some proper tests for this bug so it doesn't resurface, and there was a bit of cleanup in the process.