Skip to content

Mono cursor offset #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2012
Merged

Mono cursor offset #2012

merged 3 commits into from
Jun 23, 2012

Conversation

mcelrath
Copy link

Fix spurious appearance of the #fontarea when fonts don't have any problem.

Fixes #2005.

@fperez
Copy link
Member

fperez commented Jun 23, 2012

The code looks clean to me, and furthermore it removes the dialog, which is another win. Thanks!

Since triggering the problem in #2005 was kind of tricky (I haven't seen it), I'm going to merge this so we can have more testing in the wild.

Thanks for the quick turnaround, @mcelrath!

fperez added a commit that referenced this pull request Jun 23, 2012
Fix spurious appearance of the #fontarea when fonts don't have any problem; also remove loud dialog when problematic font is detected and simply adjust baseline.  Users will have a slightly offset baseline for bold/italic highlights, but without any functional problems.

Fixes #2005.
@fperez fperez merged commit 086258d into ipython:master Jun 23, 2012
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Fix spurious appearance of the #fontarea when fonts don't have any problem; also remove loud dialog when problematic font is detected and simply adjust baseline.  Users will have a slightly offset baseline for bold/italic highlights, but without any functional problems.

Fixes ipython#2005.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange output artifacts in footer of notebook
2 participants