ENTER submits the rename notebook dialog.

[ellisonbg]

This address issue #1596, but I am not convinced we want this. I have bound an event handler to ENTER that will click the "OK" button when ENTER is pressed. The problem is that we cant' indicate which of the two buttons is in focus - in fact neither of them is in focus because the text area has to be in focus for the user to change the name.

We may want the original behavior, which allowed the user to navigate the focus using TAB and then press the focused button using ENTER.

[takluyver]

Is there not some way of attaching the logic to the text field, so it behaves like normal HTML forms (submit on enter)?

[minrk]

Great!

I am not convinced we want this

There is simply no circumstance in which a one-field non-multiline form that doesn't submit on enter is ever okay.

[minrk]

I don't understand your qualms, what exactly is the downside of this?

[fperez]

Same here: on every single-line form I've ever seen, Enter is synonymous with submit. I've gotten used to the fact that I have to manually tab in IPython (and that should remain possible), but it seems to me this PR is a net gain too...

[ellisonbg]

Let me fix one thing with this. The only problem right now is that if
a user uses TAB to focus the "Cancel" button and them hits ENTER
we will still trigger "OK". I can fix this though so it works as
expected.

On Thu, May 31, 2012 at 6:06 PM, Fernando Perez
[email protected]
wrote:

Same here: on every single-line form I've ever seen, Enter is synonymous with submit.  I've gotten used to the fact that I have to manually tab in IPython (and that should remain possible), but it seems to me this PR is a net gain too...

---

Reply to this email directly or view it on GitHub:
#1821 (comment)

Brian E. Granger
Cal Poly State University, San Luis Obispo
[email protected] and [email protected]

[ellisonbg]

OK, this works exactly as expected now and I have cleaned the code up. Merging.