Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ipfs/aegir
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v27.0.0
Choose a base ref
...
head repository: ipfs/aegir
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v28.0.0
Choose a head ref
  • 5 commits
  • 11 files changed
  • 1 contributor

Commits on Oct 20, 2020

  1. fix: remove --noUnhandledPromiseRejections option (#653) 

    Doesn't seem to work on Linux - we should use the built in mocha
`--allow-uncaught` option instead anyway.
    @achingbrain
    achingbrain authored Oct 20, 2020
    Configuration menu
    Copy the full SHA
    e478259 View commit details
    Browse the repository at this point in the history

  2. feat: allow overriding runtime path for bundle size check (#652) 

    Not all modules built with aegir are destined to be consumed in a browser, but as currently implemented the size check will run for every package in a monorepo, which may then fail if one of those packages cannot be built as a browser bundle - if it uses node core modules, for example.

The change here is to allow passing a directory path in which to run the size check, this way monorepos can specify the modules they want tested by using a build matrix:
    
```yaml
on:
  pull_request:
    branches:
      - '*'

name: Bundlesize
jobs:
  check:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        node-version: [12.x]
        project:
          - packages/module-1
          - packages/module-2
          - packages/etc
    steps:
      - uses: actions/checkout@v2
      - name: Use Node.js ${{ matrix.node-version }}
        uses: actions/setup-node@v1
        with:
          node-version: ${{ matrix.node-version }}
      - name: Install dependencies
        run: npm install
      - name: Bundlesize ${{ matrix.project }}
        uses: ipfs/aegir/actions/bundle-size@feat/opt-in-to-size-check
        with:
          project: ${{ matrix.project }}
          github_token: ${{ secrets.GITHUB_TOKEN }}
```
    @achingbrain
    achingbrain authored Oct 20, 2020
    Configuration menu
    Copy the full SHA
    f2ad1b9 View commit details
    Browse the repository at this point in the history

  3. chore: update deps (#654) 

    Everything apart from webpack as that seems to have more involved changes.
    @achingbrain
    achingbrain authored Oct 20, 2020
    Configuration menu
    Copy the full SHA
    5516ddf View commit details
    Browse the repository at this point in the history

  4. chore: update contributors

    @achingbrain
    achingbrain committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    a614012 View commit details
    Browse the repository at this point in the history

  5. chore: release version v28.0.0

    @achingbrain
    achingbrain committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    d5afc02 View commit details
    Browse the repository at this point in the history
Loading