Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ionic-team/ionic-framework
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 87bde81
Choose a base ref
...
head repository: ionic-team/ionic-framework
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4b10d7d
Choose a head ref
  • 15 commits
  • 127 files changed
  • 12 contributors

Commits on Jan 29, 2025

  1. Configuration menu
    Copy the full SHA
    3531591 View commit details
    Browse the repository at this point in the history
  2. merge release-8.4.3 (#30166)

    v8.4.3
    brandyscarney authored Jan 29, 2025
    Configuration menu
    Copy the full SHA
    295fa00 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2025

  1. fix(segment-button): protect connectedCallback for when segment-conte…

    …nt has not yet been created (cherry-pick) (#30138)
    
    Issue number: internal
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    <!-- Please describe the current behavior that you are modifying. -->
    When the `connectedCallback` method is called for a segment-button and
    its corresponding segment-content has not been created in that instant,
    a console error is thrown and the method returns.
    
    ## What is the new behavior?
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    - `connectedCallback` will now wait, at most 1 second, for the
    corresponding segment-content to be created.
    - The new behaviour can be tested in segment-view/basic.
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    
    https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    <!-- Any other information that is important to this PR such as
    screenshots of how the component looks before and after the change. -->
    OS-pedrolourenco authored Feb 10, 2025
    Configuration menu
    Copy the full SHA
    14b6538 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2025

  1. chore(deps): update pozil/auto-assign-issue action to v2.2.0 (#30181)

    This PR contains the following updates:
    
    | Package | Type | Update | Change |
    |---|---|---|---|
    |
    [pozil/auto-assign-issue](https://redirect.github.com/pozil/auto-assign-issue)
    | action | minor | `v2.1.2` -> `v2.2.0` |
    
    ---
    
    ### Release Notes
    
    <details>
    <summary>pozil/auto-assign-issue (pozil/auto-assign-issue)</summary>
    
    ###
    [`v2.2.0`](https://redirect.github.com/pozil/auto-assign-issue/releases/tag/v2.2.0):
    - Add support for pull_request_target
    
    [Compare
    Source](https://redirect.github.com/pozil/auto-assign-issue/compare/v2.1.2...v2.2.0)
    
    - feat: Add support for pull_request_target.
    [#&#8203;152](https://redirect.github.com/pozil/auto-assign-issue/issues/152)
    thanks to [@&#8203;thedjnK](https://redirect.github.com/thedjnK)
    -   build: bump dependencies
    
    </details>
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - "every weekday before 11am" (UTC),
    Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you
    are satisfied.
    
    ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.
    
    🔕 **Ignore**: Close this PR and you won't be reminded about this update
    again.
    
    ---
    
    - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
    this box
    
    ---
    
    This PR was generated by [Mend Renovate](https://mend.io/renovate/).
    View the [repository job
    log](https://developer.mend.io/github/ionic-team/ionic-framework).
    
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNjQuMSIsInVwZGF0ZWRJblZlciI6IjM5LjE2NC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
    
    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Feb 19, 2025
    Configuration menu
    Copy the full SHA
    71e25ef View commit details
    Browse the repository at this point in the history
  2. chore(deps): update dependency @clack/prompts to ^0.10.0 (#30180)

    This PR contains the following updates:
    
    | Package | Change | Age | Adoption | Passing | Confidence |
    |---|---|---|---|---|---|
    |
    [@clack/prompts](https://redirect.github.com/natemoo-re/clack/tree/main/packages/prompts#readme)
    ([source](https://redirect.github.com/natemoo-re/clack/tree/HEAD/packages/prompts))
    | [`^0.9.0` ->
    `^0.10.0`](https://renovatebot.com/diffs/npm/@clack%2fprompts/0.9.1/0.10.0)
    |
    [![age](https://developer.mend.io/api/mc/badges/age/npm/@clack%2fprompts/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@clack%2fprompts/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@clack%2fprompts/0.9.1/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
    |
    [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@clack%2fprompts/0.9.1/0.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
    |
    
    ---
    
    ### Release Notes
    
    <details>
    <summary>natemoo-re/clack (@&#8203;clack/prompts)</summary>
    
    ###
    [`v0.10.0`](https://redirect.github.com/natemoo-re/clack/blob/HEAD/packages/prompts/CHANGELOG.md#0100)
    
    [Compare
    Source](https://redirect.github.com/natemoo-re/clack/compare/@clack/[email protected]...@clack/[email protected])
    
    ##### Minor Changes
    
    -
    [`613179d`](https://redirect.github.com/natemoo-re/clack/commit/613179d):
    Adds a new `indicator` option to `spinner`, which supports the original
    `"dots"` loading animation or a new `"timer"` loading animation.
    
        ```ts
        import * as p from "@&#8203;clack/prompts";
    
        const spin = p.spinner({ indicator: "timer" });
        spin.start("Loading");
        await sleep(3000);
        spin.stop("Loaded");
        ```
    
    -
    [`a38b2bc`](https://redirect.github.com/natemoo-re/clack/commit/a38b2bc):
    Adds `stream` API which provides the same methods as `log`, but for
    iterable (even async) message streams. This is particularly useful for
    AI responses which are dynamically generated by LLMs.
    
        ```ts
        import * as p from "@&#8203;clack/prompts";
    
        await p.stream.step(
          (async function* () {
            yield* generateLLMResponse(question);
          })()
        );
        ```
    
    </details>
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - "every weekday before 11am" (UTC),
    Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you
    are satisfied.
    
    ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.
    
    🔕 **Ignore**: Close this PR and you won't be reminded about this update
    again.
    
    ---
    
    - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
    this box
    
    ---
    
    This PR was generated by [Mend Renovate](https://mend.io/renovate/).
    View the [repository job
    log](https://developer.mend.io/github/ionic-team/ionic-framework).
    
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNjQuMSIsInVwZGF0ZWRJblZlciI6IjM5LjE2NC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
    
    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Feb 19, 2025
    Configuration menu
    Copy the full SHA
    cd5c27a View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2025

  1. fix(select): auto-scroll to selected item for all interfaces (#30202)

    Issue number: resolves #19296
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    <!-- Please describe the current behavior that you are modifying. -->
    - when the ion-select is with the interface action-sheet or alert is not
    scrolling to the selected item on open
    
    ## What is the new behavior?
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    - change test page so all select have scroll;
    - guarantee focusVisibleElement is called on all interfaces;
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    <!-- Any other information that is important to this PR such as
    screenshots of how the component looks before and after the change. -->
    
    ---------
    
    Co-authored-by: Brandy Smith <[email protected]>
    JoaoFerreira-FrontEnd and brandyscarney authored Feb 28, 2025
    Configuration menu
    Copy the full SHA
    8eaeb22 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2025

  1. chore(git): update automatic assignees (#30225)

    Co-authored-by: Brandy Smith <[email protected]>
    brandyscarney and brandyscarney authored Mar 4, 2025
    Configuration menu
    Copy the full SHA
    7794a11 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2025

  1. fix(capacitor): replace deprecated platform check method (#30195)

    Issue number: resolves internal
    
    ref: ionic-team/capacitor#7884
    
    ---------
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    `this.platform.is('capacitor')` returns `false` in Capacitor App.
    
    ## What is the new behavior?
    `this.platform.is('capacitor')` returns as expected.
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    ## Other information
    It might also need to be fixed.
    
    
    https://github.com/ionic-team/ionic-framework/blob/14b6538d98303cb753d881ec6978fb98f53ed54c/core/src/utils/test/platform.utils.ts#L32
    
    ---------
    
    Co-authored-by: ShaneK <[email protected]>
    r-yanyo and ShaneK authored Mar 6, 2025
    Configuration menu
    Copy the full SHA
    b6b43ae View commit details
    Browse the repository at this point in the history
  2. fix(capacitor): use proper types for capacitor v7 support (#30228)

    Issue number: resolves internal
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    <!-- Please describe the current behavior that you are modifying. -->
    Currently, Capacitor types are outdated in Ionic Framework and we're
    accessing a type property that no longer exists in Capacitor 7.0.0+
    
    ## What is the new behavior?
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    This PR updates the capacitor version and addresses removal of
    `.Plugins` from `@capacitor/core`'s `CapacitorGlobal`, which we rely on
    to dynamically access plugins that the user may or may not have
    installed.
    
    The fix for this was creating a custom type definition to support
    accessing `Plugins`. While `Plugins` was removed from Capacitor if we
    were accessing it directly from core, we're pulling it from the window
    in the browser, where it's still exposed, so we just needed to make our
    type reflect that.
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [X] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    <!-- Any other information that is important to this PR such as
    screenshots of how the component looks before and after the change. -->
    Technically, this issue does not prevent Framework from working with
    Capacitor 7 because it's only a typing issue, but it's still a minor
    issue that should be addressed in our effort to support Capacitor 7.
    This PR, along with #30195, should make it ready for that.
    ShaneK authored Mar 6, 2025
    Configuration menu
    Copy the full SHA
    2149ba2 View commit details
    Browse the repository at this point in the history
  3. fix(alert): change focused element and improve keyboard navigation (#…

    …30220)
    
    Issue number: internal
    
    ## What is the current behavior?
    > Once Alert gets open the focusable element was the ion-alert itself.
    > <img width="279" alt="Screenshot 2025-02-27 at 18 07 19"
    src="https://github.com/user-attachments/assets/50ad3b75-ba32-4dd1-b17e-c5a5bf16f93b"
    />
    
    
    ## What is the new behavior?
    In order to mimick native alert a11y behaviour...
    
    Changed the focused element based on the amount of existing buttons.
    > If there is only 1 button, it should be that one focused
    > <img width="304" alt="Screenshot 2025-02-27 at 18 04 52"
    src="https://github.com/user-attachments/assets/e273f65a-5347-4a29-a156-f6e57852f0dc"
    />
    
    > Otherwise it should focus the `.alert-wrapper` container
    > <img width="284" alt="Screenshot 2025-02-27 at 18 05 02"
    src="https://github.com/user-attachments/assets/4a8507f3-a31f-40b9-8cd7-478ec881e3ed"
    />
    >
    > **NOTE**: The yellow outline it's just for demo purposes, it was not
    implemented 🤪
    
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [X] No
    
    
    ## Other information
    - Also updated support to the shiftTab keyboard navigation.
    - Updated tests and screenshots with the latest changes.
    
    ---------
    
    Co-authored-by: Maria Hutt <[email protected]>
    joselrio and thetaPC authored Mar 6, 2025
    Configuration menu
    Copy the full SHA
    4df0e0f View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2025

  1. fix(range): handle unsupported values for range min and max (#30070)

    Issue number: resolves #29667
    
    ---------
    
    ## What is the current behavior?
    Currently, if min/max are set to undefined on `IonRange` (which is an
    accepted value), it breaks the DOM.
    
    ## What is the new behavior?
    After these changes, if min/max are set to undefined or any unsupported
    value (such as infinity or a NaN), it will fall back to the default
    values for min and max (currently, 1 and 100 respectively).
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    ## Other information
    
    ---------
    
    Co-authored-by: ShaneK <[email protected]>
    Co-authored-by: Brandy Smith <[email protected]>
    3 people authored Mar 7, 2025
    Configuration menu
    Copy the full SHA
    3223193 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2025

  1. fix(toggle): trigger focus and blur on click (#30234)

    Issue number: N/A
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    <!-- Please describe the current behavior that you are modifying. -->
    
    The blur and focus events do not trigger when clicking even though the
    value changes. Those events are only triggered when dragged.
    
    This leads to Angular validation to not work accurately when clicking so
    the `ion-touched` is never added to the toggle since it relies on the
    blur event.
    
    ## What is the new behavior?
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    
    - The blur and focus events also trigger on click. This follows the same
    logic as `ion-checkbox`.
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    <!-- Any other information that is important to this PR such as
    screenshots of how the component looks before and after the change. -->
    
    How to test:
    
    Recommendation to use `toggle/test/basic/index.html`:
    [Preview](https://ionic-framework-git-toggle-focus-ionic1.vercel.app/src/components/toggle/test/basic)
    
    Add the following script:
    ```js
    <script>
      document.addEventListener('ionChange', () => {
        console.log('toggle: ionChange')
      });
    
      document.addEventListener('ionFocus', () => {
        console.log('toggle: ionFocus')
      });
    
      document.addEventListener('ionBlur', () => {
        console.log('toggle: ionBlur')
      });
    </script>
    ```
    
    Verify that the focus and blur events trigger when clicking and
    dragging.
    thetaPC authored Mar 10, 2025
    Configuration menu
    Copy the full SHA
    ba8d8f4 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2025

  1. fix(vue): update output target and properly emit events (#30227)

    Issue number: resolves #30206 resolves #30178 resolves #30177 resolves
    #30175 resolves #30170
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    There have been plenty of issues reported in regards to Vue components
    failing to propagate events. It seems like when we updated the Vue
    output target and started to use the provided runtime code from the
    output target, we have changed the way how event names are computed.
    Ionic has used a custom wrapper for handling events that would kebab
    case event names. That is no longer needed and removing it fixes
    observed issues.
    
    Reproduction case working:
    https://stackblitz.com/edit/vj18czas-wdhzxjom?file=package.json
    
    ## What is the new behavior?
    We have received a fix for this in
    stenciljs/output-targets#617 which I hope will
    resolve this issue by updating the dependency.
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    Dev build: `8.4.4-dev.11741193800.14916f6f`
    christian-bromann authored Mar 11, 2025
    Configuration menu
    Copy the full SHA
    11554a5 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2025

  1. fix(vue): update output target and resolve type issues (#30239)

    Issue number: fixes #30179
    
    ---------
    
    ## What is the current behavior?
    There have been issues reported on version 8.4.3 related to the type
    information changing for Vue
    
    ## What is the new behavior?
    
    This patch updates the Vue components to be correctly types using a new
    version of the output target.
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    christian-bromann authored Mar 13, 2025
    Configuration menu
    Copy the full SHA
    6dcb143 View commit details
    Browse the repository at this point in the history
  2. v8.4.4

    Ionitron committed Mar 13, 2025
    Configuration menu
    Copy the full SHA
    4b10d7d View commit details
    Browse the repository at this point in the history
Loading